Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Support read decimal data from csv reader if user provide the schema with decimal data type to active_release #974

Merged
merged 1 commit into from Nov 24, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 23, 2021

Automatic cherry-pick of b03b80c

…with decimal data type (#941)

* support decimal data type for csv reader

* format code and fix lint check

* fix the clippy error

* enchance the parse csv to decimal and add more test
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #974 (5d4f9d8) into active_release (4fa0d4d) will increase coverage by 0.03%.
The diff coverage is 92.19%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #974      +/-   ##
==================================================
+ Coverage           82.32%   82.35%   +0.03%     
==================================================
  Files                 168      168              
  Lines               48696    48837     +141     
==================================================
+ Hits                40088    40221     +133     
- Misses               8608     8616       +8     
Impacted Files Coverage Δ
arrow/src/array/builder.rs 86.64% <ø> (ø)
arrow/src/csv/reader.rs 90.39% <92.19%> (+0.33%) ⬆️
arrow/src/datatypes/datatype.rs 65.95% <0.00%> (-0.43%) ⬇️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.13%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.45%) ⬆️
arrow/src/error.rs 17.77% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa0d4d...5d4f9d8. Read the comment docs.

@alamb alamb merged commit 6c570cf into active_release Nov 24, 2021
@alamb alamb deleted the cherry_pick_b03b80ca branch November 24, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants