[Website] Update documentations for 9.0.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good based on a quick look! One comment: can you rename the 8.0.0 directory to 8.0 ? |
|
Could someone do the rename? I'm currently away from keyboard. |
|
Can we always use |
|
Indeed, that's something we can update in the release script. Since this is passed by the person calling this script, we can also document that you need to pass the normalized version. But checking for this in the script or automatically normalizing anyway will be probably be better to prevent future mistakes. |
|
Yes. |
kou
added a commit
to kou/arrow
that referenced
this pull request
Oct 19, 2022
…ctory We should use X.Y instead of X.Y.Z (e.g.: 8.0 not 8.0.1) for previous version document directory. See also: https://github.com/apache/arrow/blob/apache-arrow-9.0.0/dev/release/post-08-docs.sh#L84 The script should accept X.Y.Z such as 8.0.1 and normalize it to X.Y. It'll reduce human error. See also: * apache/arrow-site#228 (comment) * apache/arrow-site#228 (comment)
jorisvandenbossche
pushed a commit
to apache/arrow
that referenced
this pull request
Oct 20, 2022
…ctory (#14457) We should use X.Y instead of X.Y.Z (e.g.: 8.0 not 8.0.1) for previous version document directory. See also: https://github.com/apache/arrow/blob/apache-arrow-9.0.0/dev/release/post-08-docs.sh#L84 The script should accept X.Y.Z such as 8.0.1 and normalize it to X.Y. It'll reduce human error. See also: * apache/arrow-site#228 (comment) * apache/arrow-site#228 (comment) Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
zeroshade
pushed a commit
to zeroshade/arrow
that referenced
this pull request
Oct 20, 2022
…ctory (apache#14457) We should use X.Y instead of X.Y.Z (e.g.: 8.0 not 8.0.1) for previous version document directory. See also: https://github.com/apache/arrow/blob/apache-arrow-9.0.0/dev/release/post-08-docs.sh#L84 The script should accept X.Y.Z such as 8.0.1 and normalize it to X.Y. It'll reduce human error. See also: * apache/arrow-site#228 (comment) * apache/arrow-site#228 (comment) Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
zeroshade
pushed a commit
to zeroshade/arrow
that referenced
this pull request
Oct 20, 2022
…ctory (apache#14457) We should use X.Y instead of X.Y.Z (e.g.: 8.0 not 8.0.1) for previous version document directory. See also: https://github.com/apache/arrow/blob/apache-arrow-9.0.0/dev/release/post-08-docs.sh#L84 The script should accept X.Y.Z such as 8.0.1 and normalize it to X.Y. It'll reduce human error. See also: * apache/arrow-site#228 (comment) * apache/arrow-site#228 (comment) Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
kou
added a commit
to apache/arrow
that referenced
this pull request
Oct 20, 2022
…ctory (#14457) We should use X.Y instead of X.Y.Z (e.g.: 8.0 not 8.0.1) for previous version document directory. See also: https://github.com/apache/arrow/blob/apache-arrow-9.0.0/dev/release/post-08-docs.sh#L84 The script should accept X.Y.Z such as 8.0.1 and normalize it to X.Y. It'll reduce human error. See also: * apache/arrow-site#228 (comment) * apache/arrow-site#228 (comment) Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.