Skip to content

Commit

Permalink
ARROW-5874: [Python] Fix macOS wheels to depend on system or Homebrew…
Browse files Browse the repository at this point in the history
… OpenSSL

The wheel build and test build succeeds, just the deployments fails because of removed openssl for testing: https://travis-ci.org/ursa-labs/crossbow/builds/555822505

The currently running build should pass: https://travis-ci.org/ursa-labs/crossbow/builds/555849713
although we have a bunch of warnings `<lib> was built for newer OSX version (10.12) than being linked (10.9)` for the dependencies coming from brew.

cc @xhochy

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>

Closes #4823 from kszucs/osx-wheel-openssl and squashes the following commits:

eb45ae4 <Krisztián Szűcs> reinstall openssl
ca8d177 <Krisztián Szűcs> ignore deps
be4ab0f <Krisztián Szűcs> openssl
  • Loading branch information
kszucs authored and xhochy committed Jul 8, 2019
1 parent 308b851 commit 00505b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions dev/tasks/python-wheels/osx-build.sh
Expand Up @@ -138,6 +138,7 @@ function build_wheel {
-DgRPC_SOURCE=SYSTEM \
-Dc-ares_SOURCE=BUNDLED \
-DARROW_PROTOBUF_USE_SHARED=OFF \
-DOPENSSL_USE_STATIC_LIBS=ON \
-DMAKE=make \
..
make -j5
Expand Down
4 changes: 3 additions & 1 deletion dev/tasks/python-wheels/travis.osx.yml
Expand Up @@ -68,11 +68,13 @@ install:

# test the built wheels, remove llvm and grpc dependencies to ensure
# things are properly statically-linked
- brew uninstall llvm@7 grpc c-ares
- brew uninstall --ignore-dependencies llvm@7 grpc c-ares openssl
- install_run arrow

# move built wheels to a top level directory
- mv -v arrow/python/dist/* dist/
# reinstall openssl because travis' deployment script depends on it
- brew install openssl

deploy:
provider: releases
Expand Down

0 comments on commit 00505b5

Please sign in to comment.