Skip to content

Commit

Permalink
ARROW-10646: [C++][FlightRPC] Disable flaky Flight test on Windows
Browse files Browse the repository at this point in the history
On Windows, gRPC sometimes gives us a blank peer address.

Closes #8707 from lidavidm/arrow-10646

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
  • Loading branch information
lidavidm authored and pitrou committed Nov 23, 2020
1 parent b4a0751 commit 1c18214
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cpp/src/arrow/flight/flight_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1700,7 +1700,11 @@ TEST_F(TestAuthHandler, CheckPeerIdentity) {
ASSERT_OK(results->Next(&result));
ASSERT_NE(result, nullptr);
// Action returns the peer address as the result.
#ifndef _WIN32
// On Windows gRPC sometimes returns a blank peer address, so don't
// bother checking for it.
ASSERT_NE(result->body->ToString(), "");
#endif
}

TEST_F(TestBasicAuthHandler, PassAuthenticatedCalls) {
Expand Down

0 comments on commit 1c18214

Please sign in to comment.