Skip to content

Commit

Permalink
GH-40672: [Go][Parquet] Add proper build tags for min_max (#40676)
Browse files Browse the repository at this point in the history
### Rationale for this change
Running something which calls `MinMaxInt32` on a 32-bit architecture was crashing because it wasn't dropping to the noasm solution and was calling assembly designed for a 64-bit architecture. 

### What changes are included in this PR?
Adding the same build constraints to `min_max_noasm.go` as we have on others so that it gets built for 32-bit architectures to fallback to the pure go solution.

* GitHub Issue: #40672

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
  • Loading branch information
zeroshade committed Mar 19, 2024
1 parent 07e8aa2 commit 1ee3da0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/internal/utils/min_max_noasm.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build noasm
//go:build noasm || (!amd64 && !arm64 && !s390x && !ppc64le)

package utils

Expand Down

0 comments on commit 1ee3da0

Please sign in to comment.