-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-7921: [Go] Add Reset method to various components and clean up …
…comments. The reset method allow the data structures to be re-used so they don't have to be allocated over and over again. Closes #6430 from richardartoul/ra/merge-upstream and squashes the following commits: 5a08281 <Richard Artoul> Add license to test file d76be05 <Richard Artoul> Add test for data reset d102b1f <Richard Artoul> Add tests d3e6e67 <Richard Artoul> cleanup comments c8525ae <Richard Artoul> Add Reset method to int array (#5) 489ca25 <Richard Artoul> Fix array.setData() to retain before release (#4) 88cd05f <Richard Artoul> Add reset method to Data (#3) 6d1b277 <Richard Artoul> Add Reset() method to String array (#2) dca2303 <Richard Artoul> Add Reset method to buffer and cleanup comments (#1) Lead-authored-by: Richard Artoul <richard.artoul@datadoghq.com> Co-authored-by: Richard Artoul <richardartoul@gmail.com> Signed-off-by: Sebastien Binet <binet@cern.ch>
- Loading branch information
Showing
9 changed files
with
358 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Licensed to the Apache Software Foundation (ASF) under one | ||
// or more contributor license agreements. See the NOTICE file | ||
// distributed with this work for additional information | ||
// regarding copyright ownership. The ASF licenses this file | ||
// to you under the Apache License, Version 2.0 (the | ||
// "License"); you may not use this file except in compliance | ||
// with the License. You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package array | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/apache/arrow/go/arrow" | ||
"github.com/apache/arrow/go/arrow/memory" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestDataReset(t *testing.T) { | ||
var ( | ||
buffers1 = make([]*memory.Buffer, 0, 3) | ||
buffers2 = make([]*memory.Buffer, 0, 3) | ||
) | ||
for i := 0; i < cap(buffers1); i++ { | ||
buffers1 = append(buffers1, memory.NewBufferBytes([]byte("some-bytes1"))) | ||
buffers2 = append(buffers2, memory.NewBufferBytes([]byte("some-bytes2"))) | ||
} | ||
|
||
data := NewData(&arrow.StringType{}, 10, buffers1, nil, 0, 0) | ||
data.Reset(&arrow.Int64Type{}, 5, buffers2, nil, 1, 2) | ||
|
||
for i := 0; i < 2; i++ { | ||
assert.Equal(t, buffers2, data.Buffers()) | ||
assert.Equal(t, &arrow.Int64Type{}, data.DataType()) | ||
assert.Equal(t, 1, data.NullN()) | ||
assert.Equal(t, 2, data.Offset()) | ||
assert.Equal(t, 5, data.Len()) | ||
|
||
// Make sure it works when resetting the data with its own buffers (new buffers are retained | ||
// before old ones are released.) | ||
data.Reset(&arrow.Int64Type{}, 5, data.Buffers(), nil, 1, 2) | ||
} | ||
} |
Oops, something went wrong.