Skip to content

Commit

Permalink
ARROW-3966: Fixing merge.
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Pigott committed Feb 3, 2019
1 parent 4a6de86 commit 69022c2
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public static VectorSchemaRoot sqlToArrow(
Preconditions.checkNotNull(allocator, "Memory allocator object can not be null");
Preconditions.checkNotNull(calendar, "Calendar object can not be null");

return sqlToArrow(connection, query, new JdbcToArrowConfig(allocator, calendar));
return sqlToArrow(connection, query, new JdbcToArrowConfig(allocator, calendar, false));
}

/**
Expand Down Expand Up @@ -172,7 +172,7 @@ public static VectorSchemaRoot sqlToArrow(ResultSet resultSet, BaseAllocator all
Preconditions.checkNotNull(allocator, "Memory Allocator object can not be null");

JdbcToArrowConfig config =
new JdbcToArrowConfig(allocator, Calendar.getInstance(TimeZone.getTimeZone("UTC"), Locale.ROOT));
new JdbcToArrowConfig(allocator, Calendar.getInstance(TimeZone.getTimeZone("UTC"), Locale.ROOT), false);
return sqlToArrow(resultSet, config);
}

Expand All @@ -188,7 +188,7 @@ public static VectorSchemaRoot sqlToArrow(ResultSet resultSet, Calendar calendar
Preconditions.checkNotNull(resultSet, "JDBC ResultSet object can not be null");
Preconditions.checkNotNull(calendar, "Calendar object can not be null");

return sqlToArrow(resultSet, new JdbcToArrowConfig(new RootAllocator(Integer.MAX_VALUE), calendar));
return sqlToArrow(resultSet, new JdbcToArrowConfig(new RootAllocator(Integer.MAX_VALUE), calendar, false));
}

/**
Expand All @@ -209,7 +209,7 @@ public static VectorSchemaRoot sqlToArrow(
Preconditions.checkNotNull(allocator, "Memory Allocator object can not be null");
Preconditions.checkNotNull(calendar, "Calendar object can not be null");

return sqlToArrow(resultSet, new JdbcToArrowConfig(allocator, calendar));
return sqlToArrow(resultSet, new JdbcToArrowConfig(allocator, calendar, false));
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,6 @@ public JdbcToArrowConfigBuilder setCalendar(Calendar calendar) {
* @throws NullPointerException if either the allocator or calendar was not set.
*/
public JdbcToArrowConfig build() {
return new JdbcToArrowConfig(allocator, calendar);
return new JdbcToArrowConfig(allocator, calendar, false);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public static Schema jdbcToArrowSchema(ResultSetMetaData rsmd, Calendar calendar
Preconditions.checkNotNull(rsmd, "JDBC ResultSetMetaData object can't be null");
Preconditions.checkNotNull(calendar, "Calendar object can't be null");

return jdbcToArrowSchema(rsmd, new JdbcToArrowConfig(new RootAllocator(0), calendar));
return jdbcToArrowSchema(rsmd, new JdbcToArrowConfig(new RootAllocator(0), calendar, false));
}

/**
Expand Down Expand Up @@ -270,7 +270,7 @@ public static void jdbcToArrowVectors(ResultSet rs, VectorSchemaRoot root, Calen
Preconditions.checkNotNull(root, "Vector Schema cannot be null");
Preconditions.checkNotNull(calendar, "Calendar object can't be null");

jdbcToArrowVectors(rs, root, new JdbcToArrowConfig(new RootAllocator(0), calendar));
jdbcToArrowVectors(rs, root, new JdbcToArrowConfig(new RootAllocator(0), calendar, false));
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class JdbcToArrowConfigTest {

@Test(expected = NullPointerException.class)
public void testConfigNullArguments() {
new JdbcToArrowConfig(null, null);
new JdbcToArrowConfig(null, null, false);
}

@Test(expected = NullPointerException.class)
Expand All @@ -44,7 +44,7 @@ public void testBuilderNullArguments() {

@Test(expected = NullPointerException.class)
public void testConfigNullCalendar() {
new JdbcToArrowConfig(allocator, null);
new JdbcToArrowConfig(allocator, null, false);
}

@Test(expected = NullPointerException.class)
Expand All @@ -54,7 +54,7 @@ public void testBuilderNullCalendar() {

@Test(expected = NullPointerException.class)
public void testConfigNullAllocator() {
new JdbcToArrowConfig(null, calendar);
new JdbcToArrowConfig(null, calendar, false);
}

@Test(expected = NullPointerException.class)
Expand Down

0 comments on commit 69022c2

Please sign in to comment.