-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-8129: [C++][Compute] Refine compare sort kernel
Sorting kernel implements two comparison functions, CompareValues uses array.Value() for numerical data and CompareViews uses array.GetView() for non-numerical ones. It can be simplified by using GetView() only as all data types support GetView(). This patch also refines unit test. This change improves about 40% performance. Closes #6640 from cyb70289/sort-refine Authored-by: Yibo Cai <yibo.cai@arm.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
- Loading branch information
Showing
3 changed files
with
33 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters