-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ARROW-786: [Format] In-memory format for 128-bit Decimals, handling o…
…f sign bit * Reimplement Decimal128 types to use the Int128 type as the underlying integer representation, adapted from the Apache ORC project's C++ in memory format. This enables us to write integration tests and results in an in-memory Decimal128 format that is compatible with the Java implementation * Additionaly, this PR also fixes Decimal slice comparison and adds related regression tests * Follow-ups include ARROW-695 (C++ Decimal integration tests), ARROW-696 (JSON read/write support for decimals) and ARROW-1238 (Java Decimal integration tests). Author: Phillip Cloud <cpcloud@gmail.com> Closes #981 from cpcloud/decimal-rewrite and squashes the following commits: 53ce04b [Phillip Cloud] Formatting fe13ef3 [Phillip Cloud] Remove redundant constructor 86db184 [Phillip Cloud] Subclass from FixedSizeBinaryArray for code reuse 535f9ff [Phillip Cloud] Use a macro for cases 1cc43ce [Phillip Cloud] Use CHAR_BIT 355fb24 [Phillip Cloud] Include the correct header for _BitScanReverse b53d7cd [Phillip Cloud] Share comparison code 162eeeb [Phillip Cloud] BUG: Double export b98c894 [Phillip Cloud] BUG: Export symbols be220c8 [Phillip Cloud] Cast so we have enough space to contain the integer 5716010 [Phillip Cloud] Cast 18 to matching type size_t for msvc 8833904 [Phillip Cloud] Remove unnecessary args to sto* function calls 628ce85 [Phillip Cloud] Fix more docs e4a1792 [Phillip Cloud] More const 8ecb315 [Phillip Cloud] Formatting 178d3f2 [Phillip Cloud] NOLINT for MSVC specific and necessary types 38c9b50 [Phillip Cloud] Fix doc style in int128.h and add const where possible 2930d7b [Phillip Cloud] Fix naming convention in decimal-test.cc 1eab5c4 [Phillip Cloud] Remove unnecessary header from CMakeLists.txt 22eda4b [Phillip Cloud] kMaximumPrecision 9af97d8 [Phillip Cloud] MSVC fix 349dc58 [Phillip Cloud] ARROW-786: [Format] In-memory format for 128-bit Decimals, handling of sign bit
- Loading branch information
Showing
17 changed files
with
846 additions
and
390 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.