Skip to content

Commit

Permalink
ARROW-7844: [R] Converter_List is not thread-safe
Browse files Browse the repository at this point in the history
This would trigger issues such as this:

```
Parquet file reading/writing: .........S..............Warning: stack imbalance in '.Call', 145 then 144
Warning: stack imbalance in '{', 141 then 140
Warning: stack imbalance in '{', 134 then 133
1..

══ Skipped ═════════════════════════════════════════════════════════════════════
1. write_parquet() handles various compression_level= specs (@test-parquet.R#66) - Reason: Arrow C++ not built with support for gzip

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure: Lists are preserved when writing/reading from Parquet (@test-parq
`object` not equivalent to `expected`.
Component “int”: Component 3: Numeric: lengths (4, 2) differ
```

Closes #6419 from fsaintjacques/ARROW-7844-r-flakyness and squashes the following commits:

99b0a0b <François Saint-Jacques> ARROW-7844:  Converter_List is not thread-safe

Authored-by: François Saint-Jacques <fsaintjacques@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
  • Loading branch information
fsaintjacques authored and nealrichardson committed Feb 13, 2020
1 parent b8c1f6c commit 7bcdbb3
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions r/src/array_to_vector.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,8 @@ class Converter_List : public Converter {

return Status::OK();
}

bool Parallel() const { return false; }
};

class Converter_Int64 : public Converter {
Expand Down

0 comments on commit 7bcdbb3

Please sign in to comment.