Update builder.cc

apache · Jan 17, 2018 · 8dd5eaa · 8dd5eaa
1 parent b002e0b
commit 8dd5eaa
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/cpp/src/arrow/builder.cc b/cpp/src/arrow/builder.cc
@@ -1227,8 +1227,11 @@ Status BinaryBuilder::Resize(int64_t capacity) {
 }
 
 Status BinaryBuilder::ReserveData(int64_t capacity) {
-  DCHECK_LT(capacity, std::numeric_limits<int32_t>::max());
-  return value_data_builder_.Resize(capacity * sizeof(int64_t));
+  if(value_data_length.length() + capacity > std::numeric_limits<int32_t>::max()) {
+      return Status::Invalid("Cannot reserve capacity larger than 2^31 - 1 in length for binary data");
+  }
+
+  return value_data_builder_.Resize(value_data_length.length() + capacity);
 }
 
 Status BinaryBuilder::AppendNextOffset() {