Skip to content

Commit

Permalink
Move FunctionRegistry into registry.rs
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Nov 11, 2020
1 parent 14bec1e commit aa4d569
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 18 deletions.
20 changes: 2 additions & 18 deletions rust/datafusion/src/logical_plan/mod.rs
Expand Up @@ -21,18 +21,13 @@
//! Logical query plans can then be optimized and executed directly, or translated into
//! physical query plans and executed.

use std::collections::HashSet;

use crate::error::Result;
use crate::physical_plan::udaf::AggregateUDF;
use crate::physical_plan::udf::ScalarUDF;

mod builder;
mod display;
mod expr;
mod extension;
mod operators;
mod plan;
mod registry;

pub use builder::LogicalPlanBuilder;
pub use display::display_schema;
Expand All @@ -43,15 +38,4 @@ pub use expr::{
pub use extension::UserDefinedLogicalNode;
pub use operators::Operator;
pub use plan::{LogicalPlan, PlanType, PlanVisitor, StringifiedPlan, TableSource};

/// A registry knows how to build logical expressions out of user-defined function' names
pub trait FunctionRegistry {
/// Set of all available udfs.
fn udfs(&self) -> HashSet<String>;

/// Returns a reference to the udf named `name`.
fn udf(&self, name: &str) -> Result<&ScalarUDF>;

/// Returns a reference to the udaf named `name`.
fn udaf(&self, name: &str) -> Result<&AggregateUDF>;
}
pub use registry::FunctionRegistry;
34 changes: 34 additions & 0 deletions rust/datafusion/src/logical_plan/registry.rs
@@ -0,0 +1,34 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use std::collections::HashSet;

use crate::error::Result;
use crate::physical_plan::udaf::AggregateUDF;
use crate::physical_plan::udf::ScalarUDF;

/// A registry knows how to build logical expressions out of user-defined function' names
pub trait FunctionRegistry {
/// Set of all available udfs.
fn udfs(&self) -> HashSet<String>;

/// Returns a reference to the udf named `name`.
fn udf(&self, name: &str) -> Result<&ScalarUDF>;

/// Returns a reference to the udaf named `name`.
fn udaf(&self, name: &str) -> Result<&AggregateUDF>;
}

0 comments on commit aa4d569

Please sign in to comment.