ARROW-8388: [C++][CI] Ensure Arrow compiles with GCC 4.8

Closes #6894 from bkietz/8388-GCC-4-8-fails-to-move-on- Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
apache · Apr 10, 2020 · c6e4f55 · c6e4f55
1 parent 866e6a8
commit c6e4f55
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
@@ -203,3 +203,25 @@ jobs:
       - name: Test
         shell: bash
         run: ci/scripts/python_test.sh $(pwd) $(pwd)/build
+
+  manylinux1:
+    name: AMD64 CentOS 5.11 Python 3.6 manylinux1
+    runs-on: ubuntu-latest
+    if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+    steps:
+      - name: Checkout Arrow
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Fetch Submodules and Tags
+        shell: bash
+        run: ci/scripts/util_checkout.sh
+      - name: Docker Pull
+        shell: bash
+        run: docker-compose pull centos-python-manylinux1
+      - name: Docker Run
+        shell: bash
+        run: |
+          sudo sysctl -w kernel.core_pattern="core.%e.%p"
+          ulimit -c unlimited
+          docker-compose run centos-python-manylinux1
diff --git a/cpp/src/arrow/flight/client.cc b/cpp/src/arrow/flight/client.cc
@@ -283,7 +283,7 @@ class GrpcIpcMessageReader : public ipc::MessageReader {
   ::arrow::Result<std::unique_ptr<ipc::Message>> ReadNextMessage() override {
     std::unique_ptr<ipc::Message> out;
     RETURN_NOT_OK(GetNextMessage(&out));
-    return out;
+    return std::move(out);
   }
 
  protected:

diff --git a/cpp/src/arrow/flight/server.cc b/cpp/src/arrow/flight/server.cc
@@ -104,7 +104,7 @@ class FlightIpcMessageReader : public ipc::MessageReader {
   ::arrow::Result<std::unique_ptr<ipc::Message>> ReadNextMessage() override {
     std::unique_ptr<ipc::Message> out;
     RETURN_NOT_OK(GetNextMessage(&out));
-    return out;
+    return std::move(out);
   }
 
  protected: