Skip to content

Commit

Permalink
ARROW-8375: [CI][R] Make Windows tests more verbose in case of segfault
Browse files Browse the repository at this point in the history
The verbose output will at least tell us what was being run when the crash happened.

Closes #6878 from nealrichardson/r-windows-tests

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
  • Loading branch information
nealrichardson committed Apr 8, 2020
1 parent b4bd0d8 commit c886381
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/r.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@ jobs:
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Make R tests verbose
shell: cmd
run: |
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "location"/' testthat.R
rm -f testthat.R.bak
- name: Fetch Submodules and Tags
shell: bash
run: ci/scripts/util_checkout.sh
Expand Down
5 changes: 5 additions & 0 deletions r/tests/testthat/helper-arrow.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
# Wrap testthat::test_that with a check for the C++ library
options(..skip.tests = !arrow:::arrow_available())

if (tolower(Sys.info()[["sysname"]]) == "windows") {
# See if this stabilizes tests; TODO fix the underlying issue
options(arrow.use_threads = FALSE)
}

test_that <- function(what, code) {
testthat::test_that(what, {
skip_if(getOption("..skip.tests", TRUE), "arrow C++ library not available")
Expand Down

0 comments on commit c886381

Please sign in to comment.