Skip to content

Commit

Permalink
ARROW-8333: [C++] Compile benchmarks in at least one C++ CI entry
Browse files Browse the repository at this point in the history
None of our every-commit CI builds compile the benchmarks, which may cause some of them to be broken when there are API changes.

Closes #6839 from wesm/ARROW-8333

Authored-by: Wes McKinney <wesm+git@apache.org>
Signed-off-by: Wes McKinney <wesm+git@apache.org>
  • Loading branch information
wesm committed Apr 5, 2020
1 parent ac66138 commit d1d6770
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions ci/scripts/cpp_build.sh
Expand Up @@ -47,6 +47,7 @@ pushd ${build_dir}
cmake -G "${CMAKE_GENERATOR:-Ninja}" \
-DARROW_BOOST_USE_SHARED=${ARROW_BOOST_USE_SHARED:-ON} \
-DARROW_BUILD_BENCHMARKS=${ARROW_BUILD_BENCHMARKS:-OFF} \
-DARROW_BUILD_BENCHMARKS_REFERENCE=${ARROW_BUILD_BENCHMARKS:-OFF} \
-DARROW_BUILD_EXAMPLES=${ARROW_BUILD_EXAMPLES:-OFF} \
-DARROW_BUILD_INTEGRATION=${ARROW_BUILD_INTEGRATION:-OFF} \
-DARROW_BUILD_SHARED=${ARROW_BUILD_SHARED:-ON} \
Expand Down
2 changes: 1 addition & 1 deletion ci/scripts/cpp_test.sh
Expand Up @@ -42,7 +42,7 @@ esac

pushd ${build_dir}

ctest --output-on-failure -j${n_jobs}
ctest -L unittest --output-on-failure -j${n_jobs}

if [ "${ARROW_FUZZING}" == "ON" ]; then
# Fuzzing regression tests
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
Expand Up @@ -119,6 +119,7 @@ services:
ARROW_ENABLE_TIMING_TESTS: # inherit
ARROW_USE_LD_GOLD: "ON"
ARROW_USE_PRECOMPILED_HEADERS: "ON"
ARROW_BUILD_BENCHMARKS: "ON"
volumes: &conda-volumes
- .:/arrow:delegated
- ${ARCH}-conda-cache:/build:delegated
Expand Down

0 comments on commit d1d6770

Please sign in to comment.