ARROW-223: Do not link against libpython

Author: Uwe L. Korn <uwelk@xhochy.com> Closes #95 from xhochy/arrow-223 and squashes the following commits: 4fdf1e7 [Uwe L. Korn] ARROW-223: Do not link against libpython Change-Id: I1238a48aaf94ab175b367551f74c335c6455d78a
apache · Jun 21, 2016 · f7ade7b · f7ade7b
1 parent a3e3849
commit f7ade7b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/python/cmake_modules/FindPythonLibsNew.cmake b/python/cmake_modules/FindPythonLibsNew.cmake
@@ -224,7 +224,11 @@ FUNCTION(PYTHON_ADD_MODULE _NAME )
       SET_TARGET_PROPERTIES(${_NAME} PROPERTIES LINK_FLAGS
                           "-undefined dynamic_lookup")
     ELSE()
-      TARGET_LINK_LIBRARIES(${_NAME} ${PYTHON_LIBRARIES})
+     # In general, we should not link against libpython as we do not embed
+     # the Python interpreter. The python binary itself can then define where
+     # the symbols should loaded from.
+     SET_TARGET_PROPERTIES(${_NAME} PROPERTIES LINK_FLAGS
+         "-Wl,-undefined,dynamic_lookup")
     ENDIF()
     IF(PYTHON_MODULE_${_NAME}_BUILD_SHARED)
       SET_TARGET_PROPERTIES(${_NAME} PROPERTIES PREFIX "${PYTHON_MODULE_PREFIX}")

diff --git a/python/cmake_modules/UseCython.cmake b/python/cmake_modules/UseCython.cmake
@@ -163,7 +163,6 @@ function( cython_add_module _name pyx_target_name generated_files)
   include_directories( ${PYTHON_INCLUDE_DIRS} )
   python_add_module( ${_name} ${_generated_files} ${other_module_sources} )
   add_dependencies( ${_name} ${pyx_target_name})
-  target_link_libraries( ${_name} ${PYTHON_LIBRARIES} )
 endfunction()
 
 include( CMakeParseArguments )