ARROW-7974: [C++][Developer] Fix linter warnings when PYTHONDEVMODE e…

…nabled Also fixes ARROW-7973 Closes #6549 from wesm/ARROW-7974 and squashes the following commits: 92bdd68 <Wes McKinney> Fix linter warnings in PYTHONDEVMODE Authored-by: Wes McKinney <wesm+git@apache.org> Signed-off-by: Wes McKinney <wesm+git@apache.org>
apache · Mar 6, 2020 · f8dddcd · f8dddcd
1 parent e11b602
commit f8dddcd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cpp/build-support/run_clang_format.py b/cpp/build-support/run_clang_format.py
@@ -74,8 +74,8 @@ def _check_one_file(filename, formatted):
 
     exclude_globs = []
     if arguments.exclude_globs:
-        for line in open(arguments.exclude_globs):
-            exclude_globs.append(line.strip())
+        with open(arguments.exclude_globs) as f:
+            exclude_globs.extend(line.strip() for line in f)
 
     formatted_filenames = []
     for path in lintutils.get_sources(arguments.source_dir, exclude_globs):

diff --git a/cpp/build-support/run_cpplint.py b/cpp/build-support/run_cpplint.py
@@ -74,8 +74,8 @@ def _check_some_files(completed_processes, filenames):
 
     exclude_globs = []
     if arguments.exclude_globs:
-        for line in open(arguments.exclude_globs):
-            exclude_globs.append(line.strip())
+        with open(arguments.exclude_globs) as f:
+            exclude_globs.extend(line.strip() for line in f)
 
     linted_filenames = []
     for path in lintutils.get_sources(arguments.source_dir, exclude_globs):