Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Format] C Data Interface: clarify nullability of buffer pointers #14805

Closed
pitrou opened this issue Dec 1, 2022 · 0 comments · Fixed by #14808
Closed

[Format] C Data Interface: clarify nullability of buffer pointers #14805

pitrou opened this issue Dec 1, 2022 · 0 comments · Fixed by #14808
Assignees
@pitrou
Labels
Component: Format Type: bug
Milestone
11.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Dec 1, 2022

Describe the bug, including details regarding any error messages, version, and platform.

In apache/arrow-nanoarrow#76 it was reported that some implementations may export zero-length buffers as a null pointer in the ArrowArray structure.

Given that this seems to be an accepted behavior in several implementations, we should probably make it explicitly legal in the C Data Interface spec.

Component(s)

Format
@pitrou pitrou self-assigned this Dec 1, 2022
@pitrou pitrou added this to the 11.0.0 milestone Dec 1, 2022
pitrou added a commit to pitrou/arrow that referenced this issue Dec 1, 2022
@pitrou
apacheGH-14805: [Format] C Data Interface: clarify nullability of buf…
257a30f 
…fer pointers
@github-actions github-actions bot mentioned this issue Dec 1, 2022
Merged
pitrou added a commit that referenced this issue Dec 1, 2022
@pitrou
GH-14805: [Format] C Data Interface: clarify nullability of buffer po…
0db0b1f 
…inters (#14808)

* Closes: #14805

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
pitrou added a commit to pitrou/arrow that referenced this issue Dec 1, 2022
@pitrou
DRAFT: [C++] C Data Interface: check imported buffer for non-null
9599051 
Followup to apache#14805
@pitrou pitrou mentioned this issue Dec 1, 2022
Merged
This was referenced Dec 7, 2022
Closed
Closed
pitrou added a commit to pitrou/arrow that referenced this issue Jan 17, 2023
@pitrou
DRAFT: [C++] C Data Interface: check imported buffer for non-null
e67c687 
The C data interface may expose null data pointers for zero-sized buffers.
Make sure that all buffer pointers remain non-null internally.

Followup to apacheGH-14805.
pitrou added a commit that referenced this issue Jan 17, 2023
@pitrou
GH-14875: [C++] C Data Interface: check imported buffer for non-null (#…
7319250 
…14814)

The C data interface may expose null data pointers for zero-sized buffers.
Make sure that all buffer pointers remain non-null internally.

Followup to GH-14805

* Closes: #14875

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd pushed a commit that referenced this issue Jan 18, 2023
@pitrou @raulcd
GH-14875: [C++] C Data Interface: check imported buffer for non-null (#…
8d1e357 
…14814)

The C data interface may expose null data pointers for zero-sized buffers.
Make sure that all buffer pointers remain non-null internally.

Followup to GH-14805

* Closes: #14875

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
This was referenced Jan 30, 2023
Closed
Merged
lidavidm added a commit that referenced this issue Jan 31, 2023
@lidavidm
GH-33936: [Go] C Data Interface: export dummy buffer for nil buffers (#…
5765aa2 
…33951)

### Rationale for this change

While #14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: #33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@lidavidm @sjperkins
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
843c18f 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@lidavidm
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
da86dc7 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@lidavidm @fatemehp
apacheGH-33936: [Go] C Data Interface: export dummy buffer for nil bu…
d14ca4b 
…ffers (apache#33951)

### Rationale for this change

While apache#14805 clarified that NULL buffers are valid in the C Data Interface, not all implementations handle this correctly (or were fixed, but earlier versions still exist).

### What changes are included in this PR?

Export a non-NULL dummy buffer for nil/empty buffers to ensure compatibility.

### Are these changes tested?

A regression test is included.
* Closes: apache#33936

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Format Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-14805: [Format] C Data Interface: clarify nullability of buffer pointers pitrou/arrow
1 participant
@pitrou