Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Remove usage of PlatformDependent in arrow-vector #14912

Closed
gf2121 opened this issue Dec 11, 2022 · 0 comments · Fixed by #14913
Closed

[Java] Remove usage of PlatformDependent in arrow-vector #14912

gf2121 opened this issue Dec 11, 2022 · 0 comments · Fixed by #14913
Assignees
@gf2121
Labels
Component: Java Type: enhancement
Milestone
12.0.0

Comments

@gf2121
Copy link
Contributor

gf2121 commented Dec 11, 2022

Describe the enhancement requested

For some reason our system need to set netty param io.netty.noUnsafe=true. We have replaced arrow-memory-netty with arrow-memory-unsafe. But there are still some utils in arrow-vector like DictionaryEecoder, VectorSchemaRootAppender using PlatformDependent which will cause NullPointerException when io.netty.noUnsafe=true .

IMO netty params should not affect the work of arrow-vector, can we replace the usage of PlatformDependent by ArrowBuf#setxxx ?

Component(s)

Java
@gf2121 gf2121 changed the title [Java] No more usage of PlatformDependent in arrow-vector [Java] Remove usage of PlatformDependent in arrow-vector Dec 11, 2022
@github-actions github-actions bot mentioned this issue Dec 11, 2022
Merged
lidavidm pushed a commit that referenced this issue Feb 1, 2023
@gf2121
GH-14912: [Java] Remove usage of PlatformDependent in arrow-vector, a…
5618a47 
…rrow-jdbc and arrow-algorithm (#14913)

* Closes: #14912

Authored-by: 郭峰 <guofeng.my@bytedance.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 12.0.0 milestone Feb 1, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@gf2121 @sjperkins
apacheGH-14912: [Java] Remove usage of PlatformDependent in arrow-vec…
d088e7e 
…tor, arrow-jdbc and arrow-algorithm (apache#14913)

* Closes: apache#14912

Authored-by: 郭峰 <guofeng.my@bytedance.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@gf2121
apacheGH-14912: [Java] Remove usage of PlatformDependent in arrow-vec…
1c3bdb8 
…tor, arrow-jdbc and arrow-algorithm (apache#14913)

* Closes: apache#14912

Authored-by: 郭峰 <guofeng.my@bytedance.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@gf2121 @fatemehp
apacheGH-14912: [Java] Remove usage of PlatformDependent in arrow-vec…
6c063da 
…tor, arrow-jdbc and arrow-algorithm (apache#14913)

* Closes: apache#14912

Authored-by: 郭峰 <guofeng.my@bytedance.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gf2121 gf2121

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
12.0.0
2 participants
@lidavidm @gf2121