Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Compatibility of arrow with dplyr 1.1.0 #14947

Closed
lionel- opened this issue Dec 14, 2022 · 2 comments · Fixed by #14948
Closed

[R] Compatibility of arrow with dplyr 1.1.0 #14947

lionel- opened this issue Dec 14, 2022 · 2 comments · Fixed by #14948
Assignees
@lionel-
Labels
Component: R Type: bug
Milestone
11.0.0

Comments

@lionel-
Copy link
Contributor

lionel- commented Dec 14, 2022

Describe the bug, including details regarding any error messages, version, and platform.

dplyr 1.1.0 is planned for January 27 and includes breaking/behaviour changes that need to be addressed in arrow:

  • n_distinct() no longer accepts zero arguments
  • union_all() now requires compatible arguments
  • distinct() now returns cols in supplied order
  • across() now requires an argument
  • A message generated in dplyr is compared to a hard-coded string in tests
  • semi_join() and anti_join() are stricter with unexpected arguments. Causes an issue in tests with keep.
  • slice_min() and slice_max() now require order_by

We plan to release on January 27. A pre-emptive release to fix the above would be helpful.

Component(s)

R
@lionel- lionel- mentioned this issue Dec 14, 2022
Merged
@assignUser
Copy link
Member

Thanks for the heads up @lionel-! The arrow 11.0.0 release is planned for ~ 16th of January, so we should (:crossed_fingers: ) be able to integrate these changes in 11.0.0
cc @nealrichardson @thisisnic @paleolimbot

@assignUser assignUser added this to the 11.0.0 milestone Dec 14, 2022
@assignUser
Copy link
Member

assignUser commented Dec 14, 2022 •
edited
Loading

I just saw your PR, awesome 🚀

paleolimbot added a commit that referenced this issue Dec 26, 2022
@lionel- @paleolimbot
GH-14947 [R] Compatibility with dplyr 1.1.0 (#14948)
be96d20 
Each commit in this PR fixes a breaking/behaviour change described in #14947.

I could not build the dev version of arrow so this is only tested against the CRAN version. Also there might be changes introduced since the last release that require compatibility adjustments. Could someone pick this up from here please?

Closes #14947.
* Closes: #14947

Lead-authored-by: Lionel Henry <lionel.hry@gmail.com>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@lionel- @paleolimbot @EpsilonPrime
apacheGH-14947 [R] Compatibility with dplyr 1.1.0 (apache#14948)
46fc1df 
Each commit in this PR fixes a breaking/behaviour change described in apache#14947.

I could not build the dev version of arrow so this is only tested against the CRAN version. Also there might be changes introduced since the last release that require compatibility adjustments. Could someone pick this up from here please?

Closes apache#14947.
* Closes: apache#14947

Lead-authored-by: Lionel Henry <lionel.hry@gmail.com>
Co-authored-by: Dewey Dunnington <dewey@voltrondata.com>
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@DavisVaughan DavisVaughan mentioned this issue Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lionel- lionel-

Labels
Component: R Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-14947 [R] Compatibility with dplyr 1.1.0 lionel-/arrow
2 participants
@lionel- @assignUser