Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][Docs] NOT_CRAN should be "true" instead of TRUE in R #15028

Closed
eitsupi opened this issue Dec 19, 2022 · 0 comments · Fixed by #15029
Closed

[R][Docs] NOT_CRAN should be "true" instead of TRUE in R #15028

eitsupi opened this issue Dec 19, 2022 · 0 comments · Fixed by #15029
Assignees
@eitsupi
Labels
Component: Documentation Component: R Type: bug
Milestone
11.0.0

Comments

@eitsupi
Copy link
Contributor

eitsupi commented Dec 19, 2022 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Currently on the installation manual it says the following,

arrow/r/vignettes/install.Rmd

Line 120 in dac3a00

Sys.setenv("NOT_CRAN" = TRUE)

but I think it needs to be written as Sys.setenv("NOT_CRAN" = "true") because the NOT_CRAN environment variable set by the devtools package is true, not TURE.

https://github.com/r-lib/devtools/blob/aa3f88bc693d049e1b524ca1a86b300e2c954765/R/R.R#L27
r-lib/devtools@4a44480

Component(s)

R
@eitsupi eitsupi changed the title [R] NOT_CRAN should be "true" instead of TRUE [R][Docs] NOT_CRAN should be "true" instead of TRUE Dec 19, 2022
@eitsupi eitsupi changed the title [R][Docs] NOT_CRAN should be "true" instead of TRUE [R][Docs] NOT_CRAN should be "true" instead of TRUE in R Dec 19, 2022
@github-actions github-actions bot mentioned this issue Dec 19, 2022
Merged
assignUser pushed a commit that referenced this issue Dec 21, 2022
@eitsupi
GH-15028: [R][Docs] NOT_CRAN should be "true" instead of TRUE i…
9ed98bf 
…n R (#15029)

* Closes: #15028

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 11.0.0 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eitsupi eitsupi

Labels
Component: Documentation Component: R Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15028: [R][Docs] NOT_CRAN should be "true" instead of TRUE in R eitsupi/arrow
2 participants
@assignUser @eitsupi