Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused kUnspecified enum value and simplify EnumParser. #15062

Closed
EpsilonPrime opened this issue Dec 21, 2022 · 0 comments · Fixed by #15063
Closed

Remove unused kUnspecified enum value and simplify EnumParser. #15062

EpsilonPrime opened this issue Dec 21, 2022 · 0 comments · Fixed by #15063
Assignees
@EpsilonPrime
Labels
Component: C++ Type: bug
Milestone
11.0.0

Comments

@EpsilonPrime
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

In engine/substrait/extension_set.cc EnumParser has special logic to ignore unspecified values which are typically not used. Removing the unspecified enum when it's not used will allow the parser logic to be simplified.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Dec 21, 2022
Merged
westonpace pushed a commit that referenced this issue Jan 6, 2023
@EpsilonPrime
GH-15062: [C++] Simplify EnumParser behavior (#15063)
9fcaa38 
Removes the unspecified enum from engine/substrait/extension_set.cc when it is not being used allowing the parser logic to be simplified.
* Closes: #15062

Authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 11.0.0 milestone Jan 6, 2023
EpsilonPrime added a commit to EpsilonPrime/arrow that referenced this issue Jan 6, 2023
@EpsilonPrime
apacheGH-15062: [C++] Simplify EnumParser behavior (apache#15063)
c27a48c 
Removes the unspecified enum from engine/substrait/extension_set.cc when it is not being used allowing the parser logic to be simplified.
* Closes: apache#15062

Authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
@EpsilonPrime @vibhatha
apacheGH-15062: [C++] Simplify EnumParser behavior (apache#15063)
8468d7a 
Removes the unspecified enum from engine/substrait/extension_set.cc when it is not being used allowing the parser logic to be simplified.
* Closes: apache#15062

Authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EpsilonPrime EpsilonPrime

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15062: [C++] Simplify EnumParser behavior EpsilonPrime/arrow
2 participants
@EpsilonPrime @westonpace