Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][CI] Compatibility with pandas 2.0 #15070

Closed
jorisvandenbossche opened this issue Dec 22, 2022 · 0 comments · Fixed by #34878 or #35031
Closed

[Python][CI] Compatibility with pandas 2.0 #15070

jorisvandenbossche opened this issue Dec 22, 2022 · 0 comments · Fixed by #34878 or #35031
Assignees
@jorisvandenbossche
Labels
Component: Continuous Integration Component: Python
Milestone
12.0.0

Comments

@jorisvandenbossche
Copy link
Member

#15048 added some skips for regressions in pandas main. Once those are fixed, we should remove the skips on our side.
@jorisvandenbossche jorisvandenbossche added this to the 11.0.0 milestone Dec 22, 2022
@jorisvandenbossche jorisvandenbossche self-assigned this Dec 22, 2022
@raulcd raulcd modified the milestones: 11.0.0, 12.0.0 Jan 9, 2023
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Apr 4, 2023
@jorisvandenbossche
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0
ab15964
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Apr 4, 2023
@jorisvandenbossche
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0
b5549d3
@github-actions github-actions bot mentioned this issue Apr 4, 2023
Merged
jorisvandenbossche added a commit that referenced this issue Apr 4, 2023
@jorisvandenbossche
GH-15070: [Python][CI] Compatibility with pandas 2.0 (#34878)
c4057bd 
### What changes are included in this PR?

- The issue with numpy 1.25 in the assert equal helper was fixed in pandas 1.5.3 -> removing the skip (in theory can still run into this error when using an older pandas version with the latest numpy, but that's not something you should do)
- Casting tz-aware strings to datetime64[ns] was not fixed in pandas (pandas-dev/pandas#50140) -> updating our implementation to work around it
- Casting to numpy string dtype (pandas-dev/pandas#50127) is not yet fixed -> updating the skip

### Are there any user-facing changes?

No
* Closes: #15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Apr 11, 2023
@jorisvandenbossche
apacheGH-15070: [Python][CI] Update pandas test for empty columns dty…
42a5dfe 
…pe change in pandas 2.0.1
@github-actions github-actions bot mentioned this issue Apr 11, 2023
Merged
@jorisvandenbossche jorisvandenbossche changed the title [Python][CI] Remove temporary skips for pandas 2.0 development version [Python][CI] Compatibility with pandas 2.0 Apr 11, 2023
kou pushed a commit that referenced this issue Apr 12, 2023
@jorisvandenbossche
GH-15070: [Python][CI] Update pandas test for empty columns dtype cha…
07642fd 
…nge in pandas 2.0.1 (#35031)

### Rationale for this change

Pandas changed the default dtype of the columns object for an empty DataFrame from object dtype to integer RangeIndex (see pandas-dev/pandas#52404). This updates our tests to pass with that change.

* Closes: #15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@jorisvandenbossche @liujiacheng777
apacheGH-15070: [Python][CI] Update pandas test for empty columns dty…
33ef398 
…pe change in pandas 2.0.1 (apache#35031)

### Rationale for this change

Pandas changed the default dtype of the columns object for an empty DataFrame from object dtype to integer RangeIndex (see pandas-dev/pandas#52404). This updates our tests to pass with that change.

* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0 (apache#34878
ee67c84 
)

### What changes are included in this PR?

- The issue with numpy 1.25 in the assert equal helper was fixed in pandas 1.5.3 -> removing the skip (in theory can still run into this error when using an older pandas version with the latest numpy, but that's not something you should do)
- Casting tz-aware strings to datetime64[ns] was not fixed in pandas (pandas-dev/pandas#50140) -> updating our implementation to work around it
- Casting to numpy string dtype (pandas-dev/pandas#50127) is not yet fixed -> updating the skip

### Are there any user-facing changes?

No
* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-15070: [Python][CI] Update pandas test for empty columns dty…
bcb0ece 
…pe change in pandas 2.0.1 (apache#35031)

### Rationale for this change

Pandas changed the default dtype of the columns object for an empty DataFrame from object dtype to integer RangeIndex (see pandas-dev/pandas#52404). This updates our tests to pass with that change.

* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@jorisvandenbossche @rtpsw
apacheGH-15070: [Python][CI] Compatibility with pandas 2.0 (apache#34878
23793b1 
)

### What changes are included in this PR?

- The issue with numpy 1.25 in the assert equal helper was fixed in pandas 1.5.3 -> removing the skip (in theory can still run into this error when using an older pandas version with the latest numpy, but that's not something you should do)
- Casting tz-aware strings to datetime64[ns] was not fixed in pandas (pandas-dev/pandas#50140) -> updating our implementation to work around it
- Casting to numpy string dtype (pandas-dev/pandas#50127) is not yet fixed -> updating the skip

### Are there any user-facing changes?

No
* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@jorisvandenbossche @rtpsw
apacheGH-15070: [Python][CI] Update pandas test for empty columns dty…
3de97a2 
…pe change in pandas 2.0.1 (apache#35031)

### Rationale for this change

Pandas changed the default dtype of the columns object for an empty DataFrame from object dtype to integer RangeIndex (see pandas-dev/pandas#52404). This updates our tests to pass with that change.

* Closes: apache#15070

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: Continuous Integration Component: Python
Projects
None yet
Milestone
12.0.0
2 participants
@raulcd @jorisvandenbossche