Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Separate round functionality into a separate module #15072

Closed
EpsilonPrime opened this issue Dec 22, 2022 · 0 comments · Fixed by #15073
Closed

[C++] Separate round functionality into a separate module #15072

EpsilonPrime opened this issue Dec 22, 2022 · 0 comments · Fixed by #15073
Assignees
@EpsilonPrime
Labels
Component: C++ Type: enhancement
Milestone
11.0.0

Comments

@EpsilonPrime
Copy link
Contributor

Describe the enhancement requested

40% of scalar_arithmetic.cc is comprised of round related functionality in roughly 1200 of 3000 lines of code. This is a sufficient bulk of logic to separate into its own module.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Dec 22, 2022
Merged
@AlenkaF AlenkaF changed the title Separate round functionality into a separate module [C++] Separate round functionality into a separate module Dec 23, 2022
cyb70289 pushed a commit that referenced this issue Dec 28, 2022
@EpsilonPrime
GH-15072: [C++] Move the round functionality into a separate module (#…
a0d1630 
…15073)

Splits the scalar_arithmetic.cc module into two parts.  This should make it easier for upcoming changes to round functionality to be reviewed easier.  A side effect of this refactoring is that it illuminated the lack of benchmarks for round functionality which will be addressed in a future PR.

* Closes: #15072

Authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
@cyb70289 cyb70289 added this to the 11.0.0 milestone Dec 28, 2022
EpsilonPrime added a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@EpsilonPrime
apacheGH-15072: [C++] Move the round functionality into a separate mo…
68e6caf 
…dule (apache#15073)

Splits the scalar_arithmetic.cc module into two parts.  This should make it easier for upcoming changes to round functionality to be reviewed easier.  A side effect of this refactoring is that it illuminated the lack of benchmarks for round functionality which will be addressed in a future PR.

* Closes: apache#15072

Authored-by: David Sisson <EpsilonPrime@users.noreply.github.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EpsilonPrime EpsilonPrime

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15072: [C++] Move the round functionality into a separate module EpsilonPrime/arrow
3 participants
@EpsilonPrime @cyb70289 @AlenkaF