Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++]: Substrait ProjectRel Emit Optimization #15096

Closed
vibhatha opened this issue Dec 27, 2022 · 2 comments · Fixed by #15097
Closed

[C++]: Substrait ProjectRel Emit Optimization #15096

vibhatha opened this issue Dec 27, 2022 · 2 comments · Fixed by #15097
Assignees
@vibhatha
Labels
Component: C++ Type: enhancement
Milestone
11.0.0

Comments

@vibhatha
Copy link
Collaborator

Describe the enhancement requested

At the moment, we are using nested ProjectNodes to facilitate this. The first one is the projection in the Substrait plan and the other projection is the one to select the emit fields. But this could be further optimized by just using a single ProjectNode by only using the expressions which need to be in the output.

Component(s)

C++
@vibhatha
Copy link
Collaborator Author

task

@vibhatha
Copy link
Collaborator Author

take

@github-actions github-actions bot mentioned this issue Dec 27, 2022
Merged
westonpace pushed a commit that referenced this issue Jan 4, 2023
@vibhatha
GH-15096: [C++] Substrait ProjectRel Emit Optimization (#15097)
2410d36 
This PR introduces an optimization to remove the additional `ProjectNode` used in handling emit feature for `ProjectRel`.

* Closes: #15096

Authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 11.0.0 milestone Jan 4, 2023
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@vibhatha @EpsilonPrime
apacheGH-15096: [C++] Substrait ProjectRel Emit Optimization (apache#…
a9626d4 
…15097)

This PR introduces an optimization to remove the additional `ProjectNode` used in handling emit feature for `ProjectRel`.

* Closes: apache#15096

Authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
vibhatha added a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
@vibhatha
apacheGH-15096: [C++] Substrait ProjectRel Emit Optimization (apache#…
176f702 
…15097)

This PR introduces an optimization to remove the additional `ProjectNode` used in handling emit feature for `ProjectRel`.

* Closes: apache#15096

Authored-by: vibhatha <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhatha vibhatha

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15096: [C++] Substrait ProjectRel Emit Optimization vibhatha/arrow
2 participants
@westonpace @vibhatha