Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Simplify ExecNode contract by removing the concept of "node finished" #15130

Open
westonpace opened this issue Dec 30, 2022 · 1 comment

Comments

@westonpace
Copy link
Member

Describe the enhancement requested

We've slowly been migrating to a model where all work done by the exec plan happens via the scheduler. We are at a point now where it is mostly true that "a plan is done when all of its tasks are done". We can get rid of ExecNode::finished() which has led to a few deadlocks in the exec plan because nodes would fail to mark this future finished in an error case. Any work that is not being tracked by scheduler tasks (e.g. some stuff in the source node and asof join node) should be handled by an "external task".

Component(s)

C++

@westonpace
Copy link
Member Author

This work will need to wait until #13848 merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant