GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding #15140

mapleFU · 2022-12-31T13:51:24Z

This patch support benchmark for DELTA_BINARY_PACKED. Different from PLAIN, it should considering the cases that data can or cannot be well compressed

Closes: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED #14951

github-actions · 2022-12-31T13:51:45Z

Closes: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED #14951

github-actions · 2022-12-31T13:51:47Z

⚠️ GitHub issue #14951 has been automatically assigned in GitHub to PR creator.

mapleFU · 2022-12-31T14:16:08Z

@pitrou @rok You can take a look later. Have a nice New Year's holiday~

pitrou · 2023-01-03T12:12:25Z

cpp/src/parquet/encoding_benchmark.cc

+      state, [](size_t number) { return std::vector<int32_t>(number, 64); });
+}
+
+static void BM_DeltaBitPackingEncode_Int64_Equals(benchmark::State& state) {


Do we expect different performance on this than on narrow data? Otherwise we might as well not bother.

In fact I think no different when encoding currently. Maybe it will be a impact when compress is introduced. I will paste my testing result later.

cpp/src/parquet/encoding_benchmark.cc

mapleFU · 2023-01-03T13:27:47Z

On my PC, the CPU is:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   48 bits physical, 48 bits virtual
CPU MHz:                         3899.976
BogoMIPS:                        7799.95
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       256 KiB
L1i cache:                       256 KiB
L2 cache:                        4 MiB
L3 cache:                        16 MiB

with RelWithDebInfo, benchmark result:

BM_DeltaBitPackingEncode_Int32_Equals/1024              62062 ns        62062 ns        11332 bytes_per_second=62.9413M/s
BM_DeltaBitPackingEncode_Int32_Equals/4096             236255 ns       236254 ns         2963 bytes_per_second=66.1364M/s
BM_DeltaBitPackingEncode_Int32_Equals/32768           1855954 ns      1855938 ns          378 bytes_per_second=67.3514M/s
BM_DeltaBitPackingEncode_Int32_Equals/65536           3718971 ns      3718939 ns          189 bytes_per_second=67.2235M/s
BM_DeltaBitPackingEncode_Int64_Equals/1024              62550 ns        62550 ns        11044 bytes_per_second=124.9M/s
BM_DeltaBitPackingEncode_Int64_Equals/4096             240089 ns       240086 ns         2851 bytes_per_second=130.162M/s
BM_DeltaBitPackingEncode_Int64_Equals/32768           1927331 ns      1927335 ns          361 bytes_per_second=129.713M/s
BM_DeltaBitPackingEncode_Int64_Equals/65536           3701945 ns      3701895 ns          185 bytes_per_second=135.066M/s
BM_DeltaBitPackingEncode_Int32_Narrow/1024              67811 ns        67811 ns        10285 bytes_per_second=57.605M/s
BM_DeltaBitPackingEncode_Int32_Narrow/4096             257506 ns       257508 ns         2728 bytes_per_second=60.6778M/s
BM_DeltaBitPackingEncode_Int32_Narrow/32768           1984306 ns      1984293 ns          352 bytes_per_second=62.9947M/s
BM_DeltaBitPackingEncode_Int32_Narrow/65536           3961262 ns      3961271 ns          178 bytes_per_second=63.1111M/s
BM_DeltaBitPackingEncode_Int64_Narrow/1024              69699 ns        69699 ns        10106 bytes_per_second=112.09M/s
BM_DeltaBitPackingEncode_Int64_Narrow/4096             270127 ns       270124 ns         2618 bytes_per_second=115.688M/s
BM_DeltaBitPackingEncode_Int64_Narrow/32768           2024715 ns      2024720 ns          345 bytes_per_second=123.474M/s
BM_DeltaBitPackingEncode_Int64_Narrow/65536           4028746 ns      4028677 ns          173 bytes_per_second=124.11M/s
BM_DeltaBitPackingEncode_Int32_Wide/1024                69011 ns        69012 ns        10144 bytes_per_second=56.6025M/s
BM_DeltaBitPackingEncode_Int32_Wide/4096               260263 ns       260261 ns         2696 bytes_per_second=60.0358M/s
BM_DeltaBitPackingEncode_Int32_Wide/32768             2005081 ns      2005071 ns          350 bytes_per_second=62.3419M/s
BM_DeltaBitPackingEncode_Int32_Wide/65536             3994052 ns      3994025 ns          176 bytes_per_second=62.5935M/s
BM_DeltaBitPackingEncode_Int64_Wide/1024                71563 ns        71563 ns         9796 bytes_per_second=109.17M/s
BM_DeltaBitPackingEncode_Int64_Wide/4096               269043 ns       269044 ns         2583 bytes_per_second=116.152M/s
BM_DeltaBitPackingEncode_Int64_Wide/32768             2151664 ns      2151656 ns          336 bytes_per_second=116.19M/s
BM_DeltaBitPackingEncode_Int64_Wide/65536             4174521 ns      4174501 ns          163 bytes_per_second=119.775M/s
BM_DeltaBitPackingDecode_Int32_Equal/1024               16243 ns        16243 ns        43098 bytes_per_second=240.488M/s
BM_DeltaBitPackingDecode_Int32_Equal/4096               52050 ns        52050 ns        13407 bytes_per_second=300.192M/s
BM_DeltaBitPackingDecode_Int32_Equal/32768             389390 ns       389380 ns         1790 bytes_per_second=321.023M/s
BM_DeltaBitPackingDecode_Int32_Equal/65536             768226 ns       768223 ns          914 bytes_per_second=325.426M/s
BM_DeltaBitPackingDecode_Int64_Equal/1024               22493 ns        22493 ns        31152 bytes_per_second=347.325M/s
BM_DeltaBitPackingDecode_Int64_Equal/4096               78198 ns        78198 ns         9029 bytes_per_second=399.625M/s
BM_DeltaBitPackingDecode_Int64_Equal/32768             598027 ns       598022 ns         1161 bytes_per_second=418.044M/s
BM_DeltaBitPackingDecode_Int64_Equal/65536            1192578 ns      1192553 ns          592 bytes_per_second=419.269M/s
BM_DeltaBitPackingDecode_Int32_Narrow/1024              16374 ns        16374 ns        42887 bytes_per_second=238.566M/s
BM_DeltaBitPackingDecode_Int32_Narrow/4096              52235 ns        52234 ns        13312 bytes_per_second=299.134M/s
BM_DeltaBitPackingDecode_Int32_Narrow/32768            387310 ns       387308 ns         1799 bytes_per_second=322.741M/s
BM_DeltaBitPackingDecode_Int32_Narrow/65536            777175 ns       777169 ns          888 bytes_per_second=321.68M/s
BM_DeltaBitPackingDecode_Int64_Narrow/1024              19991 ns        19991 ns        35104 bytes_per_second=390.793M/s
BM_DeltaBitPackingDecode_Int64_Narrow/4096              67224 ns        67224 ns        10499 bytes_per_second=464.863M/s
BM_DeltaBitPackingDecode_Int64_Narrow/32768            505575 ns       505252 ns         1398 bytes_per_second=494.803M/s
BM_DeltaBitPackingDecode_Int64_Narrow/65536           1001886 ns      1001880 ns          680 bytes_per_second=499.062M/s
BM_DeltaBitPackingDecode_Int32_Wide/1024                17568 ns        17568 ns        40180 bytes_per_second=222.345M/s
BM_DeltaBitPackingDecode_Int32_Wide/4096                57980 ns        57980 ns        11964 bytes_per_second=269.488M/s
BM_DeltaBitPackingDecode_Int32_Wide/32768              431183 ns       431184 ns         1642 bytes_per_second=289.899M/s
BM_DeltaBitPackingDecode_Int32_Wide/65536              835308 ns       835289 ns          724 bytes_per_second=299.298M/s
BM_DeltaBitPackingDecode_Int64_Wide/1024                22159 ns        22159 ns        31008 bytes_per_second=352.568M/s
BM_DeltaBitPackingDecode_Int64_Wide/4096                74420 ns        74421 ns         9452 bytes_per_second=419.911M/s
BM_DeltaBitPackingDecode_Int64_Wide/32768              564909 ns       564910 ns         1225 bytes_per_second=442.548M/s
BM_DeltaBitPackingDecode_Int64_Wide/65536             1128845 ns      1128847 ns          626 bytes_per_second=442.93M/s

For comparing, the Plain is:

BM_PlainEncodingInt64/1024                               2633 ns         2633 ns       264081 bytes_per_second=2.89797G/s
BM_PlainEncodingInt64/4096                               3739 ns         3739 ns       186025 bytes_per_second=8.16251G/s
BM_PlainEncodingInt64/32768                             11592 ns        11591 ns        80911 bytes_per_second=21.0623G/s
BM_PlainEncodingInt64/65536                             19921 ns        19922 ns        36999 bytes_per_second=24.5103G/s
BM_PlainDecodingInt64/1024                                488 ns          488 ns      1253972 bytes_per_second=15.6328G/s
BM_PlainDecodingInt64/4096                                900 ns          900 ns       773889 bytes_per_second=33.9169G/s
BM_PlainDecodingInt64/32768                              5802 ns         5802 ns       132464 bytes_per_second=42.0775G/s
BM_PlainDecodingInt64/65536                             12514 ns        12514 ns        59540 bytes_per_second=39.0189G/s

and dict is:

BM_DictDecodingInt64_repeats/1024                       11995 ns        11995 ns        59447 bytes_per_second=651.303M/s
BM_DictDecodingInt64_repeats/4096                       19230 ns        19229 ns        33869 bytes_per_second=1.58702G/s
BM_DictDecodingInt64_repeats/32768                      88505 ns        88504 ns         7936 bytes_per_second=2.75851G/s
BM_DictDecodingInt64_repeats/65536                     176673 ns       176672 ns         3946 bytes_per_second=2.76377G/s
BM_DictDecodingInt64_literals/1024                      45743 ns        45743 ns        15334 bytes_per_second=170.791M/s
BM_DictDecodingInt64_literals/4096                     156242 ns       156243 ns         4514 bytes_per_second=200.01M/s
BM_DictDecodingInt64_literals/32768                   1170956 ns      1170954 ns          592 bytes_per_second=213.501M/s
BM_DictDecodingInt64_literals/65536                   2298656 ns      2298664 ns          307 bytes_per_second=217.518M/s

mapleFU · 2023-01-03T14:04:07Z

(DeltaBitPackingDecode_Int32 runs much faster on my Mac with Release. I'll try to make clear why, and maybe upload some flamegraph for DELTA_BINARY_PACKED)

pitrou · 2023-01-03T14:10:36Z

DeltaBitPackingDecode_Int32 runs much faster on my Mac with Release.

Much faster than what?

mapleFU · 2023-01-03T14:29:07Z

DeltaBitPackingDecode_Int32 runs much faster on my Mac with Release.

Much faster than what?

Than running on my PC :) Hold on minutes, I'll take a bath and go back to upload some flamegraphs

I run with Release and the cpu is that:

Architecture:            arm64
Byte Order:              Little Endian

hw.cachelinesize: 128
hw.cachesize: 3626483712 65536 4194304 0 0 0 0 0 0 0
hw.l1dcachesize: 65536
hw.l1icachesize: 131072
hw.l2cachesize: 4194304

Output is:

BM_DeltaBitPackingDecode_Int64_Equal/1024         1840 ns         1684 ns       430449 bytes_per_second=4.52923G/s
BM_DeltaBitPackingDecode_Int64_Equal/4096         5182 ns         5152 ns       136641 bytes_per_second=5.92317G/s
BM_DeltaBitPackingDecode_Int64_Equal/32768       38807 ns        38666 ns        17960 bytes_per_second=6.31412G/s
BM_DeltaBitPackingDecode_Int64_Equal/65536       76972 ns        76754 ns         9151 bytes_per_second=6.36166G/s
BM_DeltaBitPackingDecode_Int64_Narrow/1024        1505 ns         1500 ns       466906 bytes_per_second=5.08796G/s
BM_DeltaBitPackingDecode_Int64_Narrow/4096        4833 ns         4792 ns       146651 bytes_per_second=6.36798G/s
BM_DeltaBitPackingDecode_Int64_Narrow/32768      36637 ns        36577 ns        18985 bytes_per_second=6.67462G/s
BM_DeltaBitPackingDecode_Int64_Narrow/65536      72851 ns        72692 ns         9634 bytes_per_second=6.71717G/s
BM_DeltaBitPackingDecode_Int64_Wide/1024          1854 ns         1820 ns       388227 bytes_per_second=4.19179G/s
BM_DeltaBitPackingDecode_Int64_Wide/4096          5843 ns         5836 ns       119740 bytes_per_second=5.22964G/s
BM_DeltaBitPackingDecode_Int64_Wide/32768        45144 ns        44884 ns        15624 bytes_per_second=5.43934G/s
BM_DeltaBitPackingDecode_Int64_Wide/65536        90276 ns        89987 ns         7807 bytes_per_second=5.42612G/s

And the PLAIN is:

BM_PlainDecodingInt64/1024         192 ns          192 ns      3694399 bytes_per_second=39.7522G/s
BM_PlainDecodingInt64/4096         578 ns          578 ns      1283556 bytes_per_second=52.8382G/s
BM_PlainDecodingInt64/32768       4404 ns         4404 ns       160711 bytes_per_second=55.44G/s
BM_PlainDecodingInt64/65536       9092 ns         9064 ns        80755 bytes_per_second=53.8693G/s

pitrou · 2023-01-03T14:43:35Z

That's indeed quite impressive...

mapleFU · 2023-01-03T15:53:32Z

After enable Release on my PC, the benchmark runs faster, maybe benifits from SIMD unpack.

BM_DeltaBitPackingDecode_Int64_Equal/1024                6339 ns         6339 ns       109683 bytes_per_second=1.20349G/s items_per_second=161.53M/s
BM_DeltaBitPackingDecode_Int64_Equal/4096               22626 ns        22626 ns        31046 bytes_per_second=1.3488G/s items_per_second=181.033M/s
BM_DeltaBitPackingDecode_Int64_Equal/32768             173717 ns       173717 ns         4018 bytes_per_second=1.40539G/s items_per_second=188.628M/s
BM_DeltaBitPackingDecode_Int64_Equal/65536             344667 ns       344667 ns         2017 bytes_per_second=1.41667G/s items_per_second=190.143M/s
BM_DeltaBitPackingDecode_Int64_Narrow/1024               5471 ns         5471 ns       129494 bytes_per_second=1.39456G/s items_per_second=187.175M/s
BM_DeltaBitPackingDecode_Int64_Narrow/4096              19144 ns        19144 ns        36988 bytes_per_second=1.59413G/s items_per_second=213.961M/s
BM_DeltaBitPackingDecode_Int64_Narrow/32768            147144 ns       147142 ns         4809 bytes_per_second=1.65921G/s items_per_second=222.696M/s
BM_DeltaBitPackingDecode_Int64_Narrow/65536            291892 ns       291889 ns         2401 bytes_per_second=1.67283G/s items_per_second=224.524M/s
BM_DeltaBitPackingDecode_Int64_Wide/1024                 6326 ns         6326 ns       110957 bytes_per_second=1.2061G/s items_per_second=161.88M/s
BM_DeltaBitPackingDecode_Int64_Wide/4096                22031 ns        22031 ns        31938 bytes_per_second=1.38523G/s items_per_second=185.923M/s
BM_DeltaBitPackingDecode_Int64_Wide/32768              170063 ns       170062 ns         4107 bytes_per_second=1.43559G/s items_per_second=192.682M/s
BM_DeltaBitPackingDecode_Int64_Wide/65536              391506 ns       391508 ns         2045 bytes_per_second=1.24718G/s items_per_second=167.394M/s

pitrou · 2023-01-03T15:59:42Z

Well, you should never run benchmarks in Debug mode.

mapleFU · 2023-01-03T16:20:43Z

Seems our tests are really unstable:

[----------] 26 tests from TestS3FS
[ RUN      ] TestS3FS.GetFileInfoRoot
[FATAL] 2023-01-03 16:03:37.808 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:37.829 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[       OK ] TestS3FS.GetFileInfoRoot (604 ms)
[ RUN      ] TestS3FS.GetFileInfoBucket
[FATAL] 2023-01-03 16:03:38.413 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:38.427 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[       OK ] TestS3FS.GetFileInfoBucket (482 ms)
[ RUN      ] TestS3FS.GetFileInfoObject
[FATAL] 2023-01-03 16:03:38.895 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:38.902 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[       OK ] TestS3FS.GetFileInfoObject (440 ms)
[ RUN      ] TestS3FS.GetFileInfoSelector
[FATAL] 2023-01-03 16:03:39.336 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:39.357 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[       OK ] TestS3FS.GetFileInfoSelector (530 ms)
[ RUN      ] TestS3FS.GetFileInfoSelectorRecursive
[FATAL] 2023-01-03 16:03:39.867 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:39.878 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[       OK ] TestS3FS.GetFileInfoSelectorRecursive (316 ms)
[ RUN      ] TestS3FS.GetFileInfoGenerator
[FATAL] 2023-01-03 16:03:40.184 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:40.196 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
D:/a/arrow/arrow/cpp/src/arrow/status.cc:137: When trying to delete temporary directory: IOError: Cannot delete directory entry 'C:/Users/RUNNER~1/AppData/Local/Temp/s3fs-test-pfipm1fp/.minio.sys': . Detail: [Windows error 145] The directory is not empty.

[       OK ] TestS3FS.GetFileInfoGenerator (590 ms)
[ RUN      ] TestS3FS.CreateDir

API: PutObject(bucket=bucket, object=somefile/)
Time: 16:03:41 UTC 01/03/2023
DeploymentID: dddc7305-986d-418a-9646-0b3874a04600
RequestID: 1736D8038C87CDA4
RemoteHost: 127.0.0.1
Host: 127.0.0.8:52054
UserAgent: aws-sdk-cpp/1.10.41 Windows/10.0.17763.2989 x86 GCC/12.2.0
Error: mkdir C:\Users\RUNNER~1\AppData\Local\Temp\s3fs-test-1un2w6b7/bucket/somefile/: Cannot create a file when that file already exists. (*fs.PathError)
       5: internal\logger\logger.go:[278](https://github.com/apache/arrow/actions/runs/3830924406/jobs/6519407271#step:11:279):logger.LogIf()
       4: cmd\fs-v1.go:1036:cmd.(*FSObjects).putObject()
       3: cmd\fs-v1.go:1012:cmd.(*FSObjects).PutObject()
       2: cmd\object-handlers.go:1830:cmd.objectAPIHandlers.PutObjectHandler()
       1: net\http\server.go:2047:http.HandlerFunc.ServeHTTP()

API: PutObject(bucket=bucket, object=somefile/)
Time: 16:03:41 UTC 01/03/2023
DeploymentID: dddc7305-986d-418a-9646-0b3874a04600
RequestID: 1736D8038C87CDA4
RemoteHost: 127.0.0.1
Host: 127.0.0.8:52054
UserAgent: aws-sdk-cpp/1.10.41 Windows/10.0.17763.2989 x86 GCC/12.2.0
Error: mkdir C:\Users\RUNNER~1\AppData\Local\Temp\s3fs-test-1un2w6b7/bucket/somefile/: Cannot create a file when that file already exists. (*fs.PathError)
       5: internal\logger\logger.go:278:logger.LogIf()
       4: cmd\api-errors.go:2123:cmd.toAPIErrorCode()
       3: cmd\api-errors.go:2148:cmd.toAPIError()
       2: cmd\object-handlers.go:1832:cmd.objectAPIHandlers.PutObjectHandler()
       1: net\http\server.go:2047:http.HandlerFunc.ServeHTTP()
[FATAL] 2023-01-03 16:03:40.775 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
[FATAL] 2023-01-03 16:03:40.799 WinHttpSyncHttpClient [1] Failed setting secure crypto protocols with error code: 87
D:/a/arrow/arrow/cpp/src/arrow/status.cc:137: When trying to delete temporary directory: IOError: Cannot delete directory entry 'C:/Users/RUNNER~1/AppData/Local/Temp/s3fs-test-1un2w6b7/.minio.sys': . Detail: [Windows error 145] The directory is not empty.

pitrou · 2023-01-03T16:25:18Z

Yes, the S3 tests are unfortunately a bit flaky, especially under Windows.

pitrou

+1, will merge if CI passes

mapleFU · 2023-01-03T16:54:26Z

Thanks, I'm sleepy now, seems the performance differences between Decode_Int64 in different input is stable, and maybe I can see why they would be like that tomorrow.

ursabot · 2023-01-04T13:42:12Z

Benchmark runs are scheduled for baseline = ceec795 and contender = 8ed4513. 8ed4513 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️25.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.04% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8ed4513c ec2-t3-xlarge-us-east-2
[Failed] 8ed4513c test-mac-arm
[Finished] 8ed4513c ursa-i9-9960x
[Failed] 8ed4513c ursa-thinkcentre-m75q
[Finished] ceec7950 ec2-t3-xlarge-us-east-2
[Failed] ceec7950 test-mac-arm
[Finished] ceec7950 ursa-i9-9960x
[Failed] ceec7950 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot · 2023-01-04T13:42:25Z

['Python', 'R'] benchmarks have high level of regressions.
ec2-t3-xlarge-us-east-2
ursa-i9-9960x

… encoding (apache#15140) This patch support benchmark for DELTA_BINARY_PACKED. Different from PLAIN, it should considering the cases that data can or cannot be well compressed * Closes: apache#14951 Lead-authored-by: mwish <anmmscs_maple@qq.com> Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>

basic impl the framework

28b0d59

github-actions bot added Component: C++ Component: Parquet labels Dec 31, 2022

support number generator to generate different inputs

f3426ef

fix some text and counting issue

1a5f5df

pitrou reviewed Jan 3, 2023

View reviewed changes

cpp/src/parquet/encoding_benchmark.cc Outdated Show resolved Hide resolved

pitrou reviewed Jan 3, 2023

View reviewed changes

cpp/src/parquet/encoding_benchmark.cc Show resolved Hide resolved

pitrou reviewed Jan 3, 2023

View reviewed changes

cpp/src/parquet/encoding_benchmark.cc Outdated Show resolved Hide resolved

mapleFU added 2 commits January 3, 2023 20:22

Merge branch 'master' into benchmark-delta-bit-packing

5278e2f

address comment

a3447b3

add ItemsProcessed

e2c516d

Factor out input generation

97c7ccd

pitrou approved these changes Jan 3, 2023

View reviewed changes

pitrou changed the title ~~GH-14951: [C++][Parquet] Support Benchmark for DELTA_BINARY_PACKED~~ GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding Jan 3, 2023

pitrou merged commit 8ed4513 into apache:master Jan 3, 2023

mapleFU deleted the benchmark-delta-bit-packing branch January 4, 2023 02:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding #15140

GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding #15140

mapleFU commented Dec 31, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 31, 2022

github-actions bot commented Dec 31, 2022

mapleFU commented Dec 31, 2022

pitrou Jan 3, 2023

mapleFU Jan 3, 2023

mapleFU commented Jan 3, 2023 •

edited

Loading

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023 •

edited

Loading

pitrou left a comment

mapleFU commented Jan 3, 2023

ursabot commented Jan 4, 2023

ursabot commented Jan 4, 2023

GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding #15140

GH-14951: [C++][Parquet] Add benchmarks for DELTA_BINARY_PACKED encoding #15140

Conversation

mapleFU commented Dec 31, 2022 • edited by github-actions bot Loading

github-actions bot commented Dec 31, 2022

github-actions bot commented Dec 31, 2022

mapleFU commented Dec 31, 2022

pitrou Jan 3, 2023

Choose a reason for hiding this comment

mapleFU Jan 3, 2023

Choose a reason for hiding this comment

mapleFU commented Jan 3, 2023 • edited Loading

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023

mapleFU commented Jan 3, 2023

pitrou commented Jan 3, 2023 • edited Loading

pitrou left a comment

Choose a reason for hiding this comment

mapleFU commented Jan 3, 2023

ursabot commented Jan 4, 2023

ursabot commented Jan 4, 2023

mapleFU commented Dec 31, 2022 •

edited by github-actions bot

Loading

mapleFU commented Jan 3, 2023 •

edited

Loading

pitrou commented Jan 3, 2023 •

edited

Loading