Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] Integration tests are failing due to clang-format version issue #15282

Closed
EpsilonPrime opened this issue Jan 9, 2023 · 4 comments · Fixed by #32972
Closed

[CI][C++] Integration tests are failing due to clang-format version issue #15282

EpsilonPrime opened this issue Jan 9, 2023 · 4 comments · Fixed by #32972

Comments

@EpsilonPrime
Copy link
Contributor

EpsilonPrime commented Jan 9, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The environment depends on libclang-common-14-dev which probably isn't being specified.

The following packages have unmet dependencies:
 clang-14 : Depends: libclang-common-14-dev (= 1:14.0.6~++20221117072312+f28c006a5895-1~exp1~20221117192323.163) but it is not going to be installed
 clang-tidy-14 : Depends: libclang-common-14-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
The command '/bin/bash -o pipefail -c latest_system_llvm=10 &&     if [ ${llvm} -gt ${latest_system_llvm} -o          ${clang_tools} -gt ${latest_system_llvm} ]; then       apt-get update -y -q &&       apt-get install -y -q --no-install-recommends           apt-transport-https           ca-certificates           gnupg           lsb-release           wget &&       wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - &&       code_name=$(lsb_release --codename --short) &&       if [ ${llvm} -gt 10 ]; then         echo "deb https://apt.llvm.org/${code_name}/ llvm-toolchain-${code_name}-${llvm} main" >            /etc/apt/sources.list.d/llvm.list;       fi &&       if [ ${clang_tools} -ne ${llvm} -a            ${clang_tools} -gt ${latest_system_llvm} ]; then         echo "deb https://apt.llvm.org/${code_name}/ llvm-toolchain-${code_name}-${clang_tools} main" >            /etc/apt/sources.list.d/clang-tools.list;       fi;     fi &&     apt-get update -y -q &&     apt-get install -y -q --no-install-recommends         clang-${clang_tools}         clang-${llvm}         clang-format-${clang_tools}         clang-tidy-${clang_tools}         llvm-${llvm}-dev &&     apt-get clean &&     rm -rf /var/lib/apt/lists*' returned a non-zero code: 100
ERROR: Service 'ubuntu-cpp' failed to build : Build failed
Error: `docker-compose --file /home/travis/build/apache/arrow/docker-compose.yml build --build-arg BUILDKIT_INLINE_CACHE=1 ubuntu-cpp` exited with a non-zero exit code 1, see the process log above.

Component(s)

C++, Continuous Integration

@raulcd
Copy link
Member

raulcd commented Jan 10, 2023

Hi @EpsilonPrime ,
Was this happening only on travis? Do you have a link to a failed build?
Thanks

@EpsilonPrime
Copy link
Contributor Author

EpsilonPrime commented Jan 10, 2023 via email

@EpsilonPrime
Copy link
Contributor Author

As to your other question -- I believe Travis is the place where we do the clang-format checks to make sure that we haven't forgotten to run clang-format. I only have been having an issue with the Travis job.

@pitrou pitrou changed the title Integration tests are failing due to clang-format version issue [CI][C++] Integration tests are failing due to clang-format version issue Jan 10, 2023
@kiszk
Copy link
Member

kiszk commented Jan 10, 2023

IMHO, to declare CLANG_TOOLS is also required recently for arm and s390x in addition to LLVM.

194f3f2

assignUser pushed a commit that referenced this issue Jan 11, 2023
# Which issue does this PR close?

<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how 
to contribute here:
  * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
  * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)


If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

    GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

    MINOR: [${COMPONENT}] ${SUMMARY}

In the case of old issues on JIRA the title also supports:

    ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
    PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

-->

Closes #15282 

# Rationale for this change

<!--
 Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
 Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
-->
This change fixes a version error for downloading clang in apt. Recent scripts require two variables `LLVM` and `CLANG_TOOLS` are defined in [`.env`](https://github.com/apache/arrow/blob/master/.env#L56-L57).

* Closes: #15282

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment