-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][C++] Integration tests are failing due to clang-format version issue #15282
Comments
Hi @EpsilonPrime , |
I have been seeing this issue on all of my C++ PRs today. Here's the only
sample I can find after getting PRs closed:
https://app.travis-ci.com/github/apache/arrow/jobs/592888013
…On Tue, Jan 10, 2023 at 12:29 AM Raúl Cumplido ***@***.***> wrote:
Hi @EpsilonPrime <https://github.com/EpsilonPrime> ,
Was this happening only on travis? Do you have a link to a failed build?
Thanks
—
Reply to this email directly, view it on GitHub
<#15282 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDDCB6B7HUVDQ45D7ZZ2LWRUMXFANCNFSM6AAAAAATWALY2U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As to your other question -- I believe Travis is the place where we do the clang-format checks to make sure that we haven't forgotten to run clang-format. I only have been having an issue with the Travis job. |
IMHO, to declare |
assignUser
pushed a commit
that referenced
this issue
Jan 11, 2023
# Which issue does this PR close? <!-- Thanks for opening a pull request! If this is your first pull request you can find detailed information on how to contribute here: * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request) * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html) If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project. Then could you also rename the pull request title in the following format? GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY} or MINOR: [${COMPONENT}] ${SUMMARY} In the case of old issues on JIRA the title also supports: ARROW-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY} PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY} --> Closes #15282 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> This change fixes a version error for downloading clang in apt. Recent scripts require two variables `LLVM` and `CLANG_TOOLS` are defined in [`.env`](https://github.com/apache/arrow/blob/master/.env#L56-L57). * Closes: #15282 Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
The environment depends on libclang-common-14-dev which probably isn't being specified.
Component(s)
C++, Continuous Integration
The text was updated successfully, but these errors were encountered: