Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Add support for MatchSubstringOptions #15285

Closed
heronshoes opened this issue Jan 10, 2023 · 4 comments · Fixed by #34725
Closed

[GLib] Add support for MatchSubstringOptions #15285

heronshoes opened this issue Jan 10, 2023 · 4 comments · Fixed by #34725
Assignees
@kou
Labels
Component: GLib Component: Ruby Type: enhancement
Milestone
12.0.0

Comments

@heronshoes
Copy link
Contributor

Describe the enhancement requested

Target option

MatchSubstringOptions

Proposed feature

Add support for MatchSubstringOptions.

Impact of this request

It will be used in these functions:

  • count_substring()
  • count_substring_regex()
  • ends_with()
  • find_substring()
  • find_substring_regex()
  • match_like()
  • match_substring()
  • match_substring_regex()
  • starts_with()

Reference of this request

https://arrow.apache.org/docs/cpp/compute.html#containment-tests

Component(s)

GLib, Ruby
@kou
Copy link
Member

kou commented Jan 11, 2023

@heronshoes Do you want to implement this? Or can I implement this?

@heronshoes
Copy link
Contributor Author

@kou Sorry I have no skill other than Ruby...

@kou
Copy link
Member

kou commented Jan 11, 2023

OK. I'll do it.

kou added a commit to kou/arrow that referenced this issue Mar 24, 2023
@kou
apacheGH-15285: [GLib] Add GArrowMatchSubstringOptions
b0c77aa
@github-actions github-actions bot mentioned this issue Mar 24, 2023
Merged
@kou kou added this to the 12.0.0 milestone Mar 25, 2023
kou added a commit that referenced this issue Mar 25, 2023
@kou
GH-15285: [GLib] Add GArrowMatchSubstringOptions (#34725)
9d0bce6 
### Rationale for this change

It's needed for match substring related kernels.

### What changes are included in this PR?

These changes add `GArrowMatchSubstringOptions`.

These changes also includes bug fixes of `GArrowIndexOptions`. Sorry.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #15285

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@heronshoes
Copy link
Contributor Author

Thanks!

rtpsw pushed a commit to rtpsw/arrow that referenced this issue Mar 27, 2023
@kou @rtpsw
apacheGH-15285: [GLib] Add GArrowMatchSubstringOptions (apache#34725)
ff032b7 
### Rationale for this change

It's needed for match substring related kernels.

### What changes are included in this PR?

These changes add `GArrowMatchSubstringOptions`.

These changes also includes bug fixes of `GArrowIndexOptions`. Sorry.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#15285

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou mentioned this issue Mar 31, 2023
Closed
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-15285: [GLib] Add GArrowMatchSubstringOptions (apache#34725)
b80d24a 
### Rationale for this change

It's needed for match substring related kernels.

### What changes are included in this PR?

These changes add `GArrowMatchSubstringOptions`.

These changes also includes bug fixes of `GArrowIndexOptions`. Sorry.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#15285

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: GLib Component: Ruby Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-15285: [GLib] Add GArrowMatchSubstringOptions kou/arrow
2 participants
@kou @heronshoes