[Java] Method can return the value bigger than long MAX_VALUE

[asfimport]

Method org.apache.drill.exec.util.DecimalUtility.adjustScaleMultiply(long input, int factor) can return the value bigger than long max value.
For example by comparison two decimal18 values 9223372036854775807 and 0.001. To adjust first value scale this method should return 9223372036854775807 * 1000 - bigger than long max value.

Class DecimalUtility.java will be a part of org.apache.arrow after renaming described in [DRILL-4455 Depend on Apache Arrow for Vector and Memory| https://issues.apache.org/jira/browse/DRILL-4455]

Environment: Apache Drill, Apache Arrow
Reporter: Vitalii Diravka
Assignee: Ji Liu / @tianchen92

Related issues:

• Decimal data type enhancements (relates to)
• Eliminate spaces, special characters from names in function templates (is related to)

PRs and other links:

• GitHub Pull Request #4266

_{Note: This issue was originally created as ARROW-61. Please see the migration documentation for further details.}

[asfimport]

Fangzhou:
Could you please clarify which method has the problem?

[asfimport]

Vitalii Diravka:
[~lfz_carlos] This is adjustScaleMultiply(long input, int factor) method. I have already mentioned where it is in drill.
In apache arrow this is org/apache/arrow/vector/util/DecimalUtility.java class.

public static long adjustScaleMultiply(long input, int factor) {
      int index = Math.abs(factor);
      assert index >= 0 && index < scale_long_constants.length;
      if (factor >= 0) {
        return input * scale_long_constants[index];
      } else {
        return input / scale_long_constants[index];
      }
    }

[asfimport]

Wes McKinney / @wesm:
Is this still an issue?

[asfimport]

Ji Liu / @tianchen92:
@wesm I checked the code and found that the problem still exists. BTW, Drill have removed these methods in DRILL-6421, I would like to provide a PR to remove these unused methods, what do you think?

[asfimport]

Wes McKinney / @wesm:
Sure, please go ahead

[asfimport]

Ji Liu / @tianchen92:
@wesm Thanks very much for your reply, I have submitted a [PR|[https://github.com//pull/4266]], please take a look, thanks!