ARROW-61: [Java] Method can return the value bigger than long MAX_VALUE #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wesm |
|
I believe we use these methods in Dremio. Can you confirm that they are not used before removing? |
|
@jacques-n Thanks for your comments, I have checked code in Dremio(https://github.com/dremio/dremio-oss). DecimalUtility is used in some places, but the deletion methods are not used anymore. |
|
LGTM. It may be good to have Decimal data type enhancements in Apache Arrow. |
siddharthteotia
approved these changes
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ARROW-61, remove unused methods since they are removed from DRILL-6421.