Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Avoid superfluous string creation when logging level is disabled #15858

Closed
asfimport opened this issue Nov 3, 2018 · 1 comment
Closed

Comments

@asfimport
Copy link

There are a few places where strings were unnecessarily created for logging purpose.

LOGGER.debug(String.format("Buffer in RecordBatch at %d, length: %d", offset, size));

For the above scenario in ArrowRecordBatch, roughly 2/3 of the total CPU was spent in string.format()

Reporter: Zhenyuan Zhao / @zzhao0
Assignee: Zhenyuan Zhao / @zzhao0

PRs and other links:

Note: This issue was originally created as ARROW-3694. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Uwe Korn / @xhochy:
Issue resolved by pull request 2894
#2894

@asfimport asfimport added this to the 0.12.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant