ARROW-3694: [Java] Avoid superfluous string creation when logging level is disabled #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhao0
changed the title
jacques-n
reviewed
Nov 1, 2018
| @@ -82,7 +82,7 @@ protected Schema readSchema() throws IOException { | |||
| throw new InvalidArrowFileException("invalid footer length: " + footerLength); | |||
| } | |||
| long footerOffset = footerLengthOffset - footerLength; | |||
| LOGGER.debug(String.format("Footer starts at %d, length: %d", footerOffset, footerLength)); | |||
| LOGGER.debug("Footer starts at %d, length: %d", footerOffset, footerLength); | |||
There was a problem hiding this comment.
I believe you need to use {} for logback.
|
LGTM +1. Thanks for the improvements @zzhao0 |
|
@zzhao0 can you create a JIRA issue for this? |
|
Sorry @wesm, I should have noticed that missing. |
|
Will do. Thanks for the reminder |
zzhao0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where strings were unnecessarily created for logging purpose. For the scenario I profiled, for MessageSerializer.deserialize(), roughly 2/3 of the total CPU was spent in string.format() (inside ArrowRecordBatch)