Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][JS] Fix map type to allow non-standard field names #17168

Closed
asfimport opened this issue May 6, 2020 · 0 comments · Fixed by #37122
Closed

[Integration][JS] Fix map type to allow non-standard field names #17168

asfimport opened this issue May 6, 2020 · 0 comments · Fixed by #37122
Labels
Component: Integration Component: JavaScript Type: enhancement

Comments

@asfimport
Copy link

Javascript should support the integration test added in ARROW-7173.

Reporter: Antoine Pitrou / @pitrou

Note: This issue was originally created as ARROW-8716. Please see the migration documentation for further details.
trxcllnt added a commit to trxcllnt/arrow that referenced this issue Aug 24, 2023
@trxcllnt
Enforce map child field names. Fixes apache#17168
ccf19bb
@trxcllnt trxcllnt mentioned this issue Aug 24, 2023
Merged
domoritz pushed a commit that referenced this issue Sep 7, 2023
@trxcllnt
GH-31621: [JS] Fix Union null bitmaps (#37122)
b957847 
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test.

The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout):
> Unlike other data types, unions do not have their own validity bitmap.

Therefore we need to remove null masks from union types and allow them to delegate validity to their children.

Also fixes #37063 for good measure.

* Closes: #31621
* Closes: #37063
* Closes #24123
* Closes #17168

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Dominik Moritz <domoritz@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@trxcllnt @loicalleyne
apacheGH-31621: [JS] Fix Union null bitmaps (apache#37122)
abe3d11 
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test.

The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout):
> Unlike other data types, unions do not have their own validity bitmap.

Therefore we need to remove null masks from union types and allow them to delegate validity to their children.

Also fixes apache#37063 for good measure.

* Closes: apache#31621
* Closes: apache#37063
* Closes apache#24123
* Closes apache#17168

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Dominik Moritz <domoritz@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@trxcllnt @dgreiss
apacheGH-31621: [JS] Fix Union null bitmaps (apache#37122)
7ada4f8 
This PR fixes `Union` null handling, and re-enables the disabled `SparseUnion` test.

The format doc [says](https://arrow.apache.org/docs/format/Columnar.html#union-layout):
> Unlike other data types, unions do not have their own validity bitmap.

Therefore we need to remove null masks from union types and allow them to delegate validity to their children.

Also fixes apache#37063 for good measure.

* Closes: apache#31621
* Closes: apache#37063
* Closes apache#24123
* Closes apache#17168

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Dominik Moritz <domoritz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Integration Component: JavaScript Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-31621: [JS] Fix Union null bitmaps trxcllnt/arrow
1 participant
@asfimport