Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Cython 0.25.2 compilation failure #18258

Closed
asfimport opened this issue Mar 13, 2018 · 3 comments
Closed

[Python] Cython 0.25.2 compilation failure #18258

asfimport opened this issue Mar 13, 2018 · 3 comments

Comments

@asfimport
Copy link

Observed on master branch

Error compiling Cython file:
------------------------------------------------------------
...
        if hasattr(self, 'as_py'):
            return repr(self.as_py())
        else:
            return super(Scalar, self).__repr__()

    def __eq__(self, other):
   ^
------------------------------------------------------------

/home/wesm/code/arrow/python/pyarrow/scalar.pxi:67:4: Special method __eq__ must be implemented via __richcmp__

Error compiling Cython file:
------------------------------------------------------------
...
        Return true if the tensors contains exactly equal data
        """
        self._validate()
        return self.tp.Equals(deref(other.tp))

    def __eq__(self, other):
   ^
------------------------------------------------------------

/home/wesm/code/arrow/python/pyarrow/array.pxi:571:4: Special method __eq__ must be implemented via __richcmp__

Error compiling Cython file:
------------------------------------------------------------
...
        cdef c_bool result = False
        with nogil:
            result = self.buffer.get().Equals(deref(other.buffer.get()))
        return result

    def __eq__(self, other):
   ^
------------------------------------------------------------

/home/wesm/code/arrow/python/pyarrow/io.pxi:675:4: Special method __eq__ must be implemented via __richcmp__

Upgrading Cython made this go away. We should probably use __richcmp__ though

Reporter: Wes McKinney / @wesm
Assignee: Antoine Pitrou / @pitrou

PRs and other links:

Note: This issue was originally created as ARROW-2305. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Uwe Korn / @xhochy:
Would raising tge minimal required cython version be ok for us?

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
I would be fine with raising the minimum Cython version.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Issue resolved by pull request 1863
#1863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants