Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2305: [Python] Bump Cython requirement to 0.27+ #1863

Closed
wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Apr 9, 2018

Starting with Cython 0.27, it's possible to implement comparisons using __eq__ and friends instead of __richcmp__: http://docs.cython.org/en/latest/src/changes.html#id16

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@pitrou
Copy link
Member Author

pitrou commented Apr 9, 2018

AppVeyor build at https://ci.appveyor.com/project/pitrou/arrow/build/1.0.270

The Travis-CI failure is unrelated.

@pitrou pitrou closed this in f56d765 Apr 9, 2018
@pitrou pitrou deleted the ARROW-2305-cython-027 branch April 9, 2018 15:47
pitrou pushed a commit that referenced this pull request Apr 19, 2018
…ity checks against no…

…n pyarrow objects

Bumped cython version makes it possible #1863

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>

Closes #1914 from kszucs/ARROW-2423 and squashes the following commits:

1f6339f <Krisztián Szűcs> enable datatype, field and plasma objectid equality checks against non pyarrow objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants