Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Enable GitHub Actions CI for MATLAB Interface on Windows #20047

Closed
asfimport opened this issue Dec 22, 2021 · 2 comments · Fixed by #35792
Closed

[MATLAB] Enable GitHub Actions CI for MATLAB Interface on Windows #20047

asfimport opened this issue Dec 22, 2021 · 2 comments · Fixed by #35792
Assignees
@leihou6116
Labels
Component: MATLAB Type: task
Milestone
13.0.0

Comments

@asfimport
Copy link
Collaborator

Enable CI and Testing for MATLAB submissions to the Apache Arrow project on GitHub. This task can be worked on after MATLAB Actions is enabled on Windows.

Reporter: Fiona La / @lafiona

Note: This issue was originally created as ARROW-15196. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Todd Farmer / @toddfarmer:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@leihou6116
Copy link
Contributor

Take

leihou6116 added a commit to mathworks/arrow that referenced this issue May 26, 2023
@leihou6116
Merge branch 'apache:main' into apacheGH-20047
b5914a8
@github-actions github-actions bot mentioned this issue May 26, 2023
Merged
leihou6116 added a commit to mathworks/arrow that referenced this issue Jun 1, 2023
@leihou6116
Merge branch 'apache:main' into apacheGH-20047
783a428
leihou6116 added a commit to mathworks/arrow that referenced this issue Jun 21, 2023
@leihou6116
Merge branch 'apache:main' into apacheGH-20047
7ceae6e
leihou6116 added a commit to mathworks/arrow that referenced this issue Jun 21, 2023
@leihou6116
Merge branch 'apacheGH-20047' of https://github.com/mathworks/arrow i…
86a474d 
…nto apacheGH-20047
leihou6116 added a commit to mathworks/arrow that referenced this issue Jun 22, 2023
@leihou6116
Merge branch 'apache:main' into apacheGH-20047
4d392b2
leihou6116 added a commit to mathworks/arrow that referenced this issue Jun 26, 2023
@leihou6116
Merge branch 'apacheGH-20047' of https://github.com/mathworks/arrow i…
c7b9db0 
…nto apacheGH-20047
leihou6116 added a commit to mathworks/arrow that referenced this issue Jul 5, 2023
@leihou6116
Merge branch 'apache:main' into apacheGH-20047
65e4b91
@kou kou closed this as completed in #35792 Jul 7, 2023
kou pushed a commit that referenced this issue Jul 7, 2023
@leihou6116
GH-20047: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on W…
3c9b457 
…indows (#35792)

### Rationale for this change
Currently GitHub Actions builds arrow/matlab on Linux and Mac but not on Windows. This change is to enable the build on Windows such that we have qualification coverage on all popular platforms.

### What changes are included in this PR?
The build on windows uses Ninja and Visual Studio to build. This submission is aimed to enable the CI on Windows. In the future, we'll try to build using Ninja and MinGW.

### Are these changes tested?
Yes. When I submitted the change, I verified that the Windows CI was enabled that tests were run successfully.

### Are there any user-facing changes?
No.

### Future Direction
On Windows, use Ninja+MinGW to build to remove the dependency on Visual Studio.

* Closes: #20047

Authored-by: Lei Hou <leihou@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leihou6116 leihou6116

Labels
Component: MATLAB Type: task
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-20047: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on Windows mathworks/arrow
3 participants
@kou @leihou6116 @asfimport