Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Using better namespace style when using protobuf with Substrait #20401

Closed
asfimport opened this issue Sep 8, 2022 · 1 comment
Closed

Comments

@asfimport
Copy link
Collaborator

At the moment the namespace usage in Substrait is not consistent when it comes to using Protobuf classes in serialization and deserialization tasks. 

 

For example: 

Instead of substrait::ReadRel_LocalFiles_FileOrFiles use substrait::ReadRel::LocalFiles::FileOrFiles

 

Reporter: Vibhatha Lakmal Abeykoon / @vibhatha
Assignee: Vibhatha Lakmal Abeykoon / @vibhatha

PRs and other links:

Note: This issue was originally created as ARROW-17647. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Weston Pace / @westonpace:
Issue resolved by pull request 14121
#14121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant