Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17647: [C++] Using better namespace style when using protobuf with Substrait #14121

Merged
merged 2 commits into from
Sep 19, 2022
Merged

ARROW-17647: [C++] Using better namespace style when using protobuf with Substrait #14121

merged 2 commits into from
Sep 19, 2022

Conversation

vibhatha
Copy link
Collaborator

This PR includes minor changes to the namespace usage in Substrait integation.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17647

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

westonpace
westonpace approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@westonpace westonpace merged commit b97497a into apache:master Sep 19, 2022
@ursabot
Copy link

ursabot commented Sep 20, 2022

Benchmark runs are scheduled for baseline = 7969164 and contender = b97497a. b97497a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.27% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.5% ⬆️0.14%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b97497aa ec2-t3-xlarge-us-east-2
[Failed] b97497aa test-mac-arm
[Failed] b97497aa ursa-i9-9960x
[Finished] b97497aa ursa-thinkcentre-m75q
[Finished] 79691649 ec2-t3-xlarge-us-east-2
[Finished] 79691649 test-mac-arm
[Failed] 79691649 ursa-i9-9960x
[Finished] 79691649 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@vibhatha @zagto
ARROW-17647: [C++] Using better namespace style when using protobuf w…
daae1ce 
…ith Substrait (apache#14121)

This PR includes minor changes to the namespace usage in Substrait integation.

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@vibhatha @fatemehp
ARROW-17647: [C++] Using better namespace style when using protobuf w…
4553c50 
…ith Substrait (apache#14121)

This PR includes minor changes to the namespace usage in Substrait integation.

Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vibhatha @ursabot @westonpace