Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Build against nightly Rust in CI #20445

Closed
asfimport opened this issue Nov 24, 2018 · 4 comments
Closed

[Rust] Build against nightly Rust in CI #20445

asfimport opened this issue Nov 24, 2018 · 4 comments

Comments

@asfimport
Copy link

In order to allow the parquet-rs code to be contributed, we need to move to using nightly Rust. We should build against both stable and nightly and allow failures against stable.

Reporter: Andy Grove / @andygrove
Assignee: Andy Grove / @andygrove

PRs and other links:

Note: This issue was originally created as ARROW-3868. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Andy Grove / @andygrove:
Nightly and Stable Rust currently have different code formatting rules, so it is not possible to have both of them pass with the same code base.

@asfimport
Copy link
Author

Chao Sun / @sunchao:
Can we skip the format check in stable? and I assume we had the same issue when using stable as default, is that right?

@asfimport
Copy link
Author

Andy Grove / @andygrove:
Good idea. I just updated the PR to use separate scripts for stable vs nightly and only run the formatting checks for nightly.

@asfimport
Copy link
Author

Andy Grove / @andygrove:
Issue resolved by pull request 3034
#3034

@asfimport asfimport added this to the 0.12.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants