[C++] Return more specific invalid Status in Take kernel

[asfimport]

Currently the Take kernel returns generic Invalid Status for certain cases, that could use more specific error:

• indices of wrong type (eg floats) -> TypeError instead of Invalid?

• out of bounds index -> new IndexError ?

  From review in ARROW-5291: [Python] Add wrapper for take kernel on Array #4281

  cc @bkietz

Reporter: Joris Van den Bossche / @jorisvandenbossche
Assignee: Ben Kietzman / @bkietz

Related issues:

• [C++] Implement take kernel functions (is related to)

PRs and other links:

• GitHub Pull Request #4317

_{Note: This issue was originally created as ARROW-5311. Please see the migration documentation for further details.}

[asfimport]

Antoine Pitrou / @pitrou:
I think we could probably add a Status::IndexError on the C++ side to designate out-of-bounds conditions (when detected :-)). @wesm @xhochy what do you think?

[asfimport]

Wes McKinney / @wesm:
Seems OK to me, interested in other opinions

[asfimport]

Ben Kietzman / @bkietz:
Alternatively: we could just use KeyError

[asfimport]

Joris Van den Bossche / @jorisvandenbossche:
With IndexError, we could match typical behaviour on the python side (out of bound indices give IndexError in Python), but of course this is specific to Python, so that should not necessarily drive a change on the C++ side.

[asfimport]

Antoine Pitrou / @pitrou:
KeyError is more for column or field names etc.

[asfimport]

Antoine Pitrou / @pitrou:
Issue resolved by pull request 4317
#4317