Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-5291: [Python] Add wrapper for take kernel on Array #4281

Closed
wants to merge 5 commits into from
Closed

ARROW-5291: [Python] Add wrapper for take kernel on Array #4281

wants to merge 5 commits into from

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche
Copy link
Member Author

The failure is due to assert pa.total_allocated_bytes() == 0, which I first thought was unrelated, but reading #2385, it seems this is related? So we can use parametrize, but not with creating arrays in it?

@pitrou
Copy link
Member

pitrou commented May 13, 2019

So we can use parametrize, but not with creating arrays in it?

Right... or perhaps we can revisit that total_allocated_bytes test (for example run it in a subprocess).

pitrou
pitrou approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for CI now.

@pitrou
Copy link
Member

pitrou commented May 13, 2019

@jorisvandenbossche Did you enable AppVeyor on your fork? It can help get results faster when the Arrow build queue is long.

@jorisvandenbossche
Copy link
Member Author

Ah, not yet. Activated that now, thanks!

@pitrou
Copy link
Member

pitrou commented May 13, 2019

The remaining Travis-CI failure is unrelated.

@pitrou pitrou closed this in 2ca6fe8 May 13, 2019
@jorisvandenbossche jorisvandenbossche deleted the ARROW-5291-array-take branch May 13, 2019 18:14
@jorisvandenbossche
Copy link
Member Author

Thanks!

emkornfield pushed a commit to emkornfield/arrow that referenced this pull request May 16, 2019
@jorisvandenbossche @emkornfield
ARROW-5291: [Python] Add wrapper for take kernel on Array
21ae415 
https://issues.apache.org/jira/browse/ARROW-5291

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>

Closes apache#4281 from jorisvandenbossche/ARROW-5291-array-take and squashes the following commits:

f5e82b9 <Joris Van den Bossche> remove array creation into test body
4d70b93 <Joris Van den Bossche> Merge remote-tracking branch 'upstream/master' into ARROW-5291-array-take
e24397c <Joris Van den Bossche> Merge remote-tracking branch 'upstream/master' into ARROW-5291-array-take
bd72d70 <Joris Van den Bossche> add tests for empty indices
1f65936 <Joris Van den Bossche> ARROW-5291:  Add wrapper for take kernel on Array
This was referenced May 13, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorisvandenbossche @pitrou