Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer Tools] Cannot merge PRs from authors with "Á" (U+00C1) in their name #23051

Closed
asfimport opened this issue Sep 26, 2019 · 5 comments

Comments

@asfimport
Copy link

I tried merging a PR from Ádám Lippai (https://github.com/alippai) and the merge script failed with:

 

./dev/merge_arrow_pr.py 
ARROW_HOME = /home/andy/git/andygrove/arrow/dev
PROJECT_NAME = arrow
Which pull request would you like to merge? (e.g. 34): 5499
Env APACHE_JIRA_USERNAME not set, please enter your JIRA username:andygrove
Env APACHE_JIRA_PASSWORD not set, please enter your JIRA password:*********
=== Pull Request #5499 ===
title	ARROW-6705: [Rust] [DataFusion] README has invalid github URL
source	alippai/patch-1
target	master
url	https://api.github.com/repos/apache/arrow/pulls/5499
=== JIRA ARROW-6705 ===
Summary		[Rust] [DataFusion] README has invalid github URL
Assignee	NOT ASSIGNED!!!
Components	Rust
Status		Open
URL		https://issues.apache.org/jira/browse/ARROW-6705Proceed with merging pull request #5499? (y/n): y
Switched to branch 'PR_TOOL_MERGE_PR_5499_MASTER'
Automatic merge went well; stopped before committing as requested
Traceback (most recent call last):
  File "./dev/merge_arrow_pr.py", line 571, in <module>
    cli()
  File "./dev/merge_arrow_pr.py", line 556, in cli
    pr.merge()
  File "./dev/merge_arrow_pr.py", line 354, in merge
    print("Author {}: {}".format(i + 1, author))
UnicodeEncodeError: 'ascii' codec can't encode character u'\xc1' in position 0: ordinal not in range(128)
 

Reporter: Andy Grove / @andygrove
Assignee: Andy Grove / @andygrove

Note: This issue was originally created as ARROW-6706. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Are you using Python 2 or Python 3? If the former, try Python 3.

@asfimport
Copy link
Author

Andy Grove / @andygrove:
Thanks Antoine. Using python3 fixed it.

@asfimport
Copy link
Author

Wes McKinney / @wesm:
If we werent bidding farewell to Python 2 in 3 months I would say to fix it but at this point not worth it

@asfimport
Copy link
Author

Neal Richardson / @nealrichardson:
Can we fail explicitly if someone uses Python 2 and tell them to use Python 3?

@asfimport
Copy link
Author

Antoine Pitrou / @pitrou:
Probably :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants