Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] packed_simd requires nightly #23061

Closed
Tracked by #23060
asfimport opened this issue Sep 26, 2019 · 4 comments
Closed
Tracked by #23060

[Rust] packed_simd requires nightly #23061

asfimport opened this issue Sep 26, 2019 · 4 comments

Comments

@asfimport
Copy link

asfimport commented Sep 26, 2019

See rust-lang/rfcs#2366 for more info on stabilization of this crate.

 

error[E0554]: `#![feature]` may not be used on the stable release channel
   --> /home/andy/.cargo/registry/src/github.com-1ecc6299db9ec823/packed_simd-0.3.3/src/lib.rs:202:1
    |
202 | / #![feature(
203 | |     repr_simd,
204 | |     const_fn,
205 | |     platform_intrinsics,
...   |
215 | |     custom_inner_attributes
216 | | )]
    | |__^
 

Reporter: Andy Grove / @andygrove

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-6718. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neville Dipale / @nevi-me:
If everyone's happy with the performance of arithmetic and compute kernels after the improvements to the non-SIMD functions (ARROW-7460), I'd like to propose removing packed_simd @paddyhoran

@asfimport
Copy link
Author

Paddy Horan / @paddyhoran:
I would love to get back on stable.  I added a feature to disable explicit SIMD to try and make progress toward this goal.  Although the main thing we need is specialization on stable.

 

If we can get the same level of performance then I'm all for removing packed_simd.  At the time we adopted it, the author was trying to get it adopted into std.  Since then he has stopped driving this forward until other features land.

 

I'll take a look in the next few days to compare performance, etc. 

@asfimport
Copy link
Author

Kyle Strand:
There is now a portable-SIMD Rust language working group: https://blog.rust-lang.org/inside-rust/2020/09/29/Portable-SIMD-PG.html

Their goal is to make "a portable SIMD API available to stable Rust users." We should follow their progress and adopt their recommendations.

@asfimport
Copy link
Author

Andrew Lamb / @alamb:
Migrated to github: apache/arrow-rs#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant