Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Eliminate indirection of ZST allocations #24791

Closed
asfimport opened this issue Apr 29, 2020 · 1 comment
Closed

[Rust] Eliminate indirection of ZST allocations #24791

asfimport opened this issue Apr 29, 2020 · 1 comment

Comments

@asfimport
Copy link

Currently, no matter what any array construction without data creates 0 sized layouts and passes itself to Rust's allocator API, thus OS then comes back to the program and does the job.

This issue is two-fold:

  • First, this creates indirection and UB in a sense.

  • Second, degrades the performance for the merging simd, merging arrays, constructing arrays etc. and intermediate arrays when doing ops. over them.

    The solution would be:

  • Having UB solved without a performance downside.

  • Improve the performance

Reporter: Mahmut Bulut / @vertexclique
Assignee: Mahmut Bulut / @vertexclique

PRs and other links:

Note: This issue was originally created as ARROW-8629. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Andy Grove / @andygrove:
Issue resolved by pull request 7061
#7061

@asfimport asfimport added this to the 1.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant