Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Gandiva] SelectionVector related test failed on big-endian platforms #24925

Closed
asfimport opened this issue May 12, 2020 · 1 comment
Closed

Comments

@asfimport
Copy link
Collaborator

These test failures in gandiva tests occur on big-endian platforms

...
[----------] 11 tests from TestSelectionVector
[ RUN      ] TestSelectionVector.TestInt16Make
[       OK ] TestSelectionVector.TestInt16Make (0 ms)
[ RUN      ] TestSelectionVector.TestInt16MakeNegative
[       OK ] TestSelectionVector.TestInt16MakeNegative (1 ms)
[ RUN      ] TestSelectionVector.TestInt16Set
[       OK ] TestSelectionVector.TestInt16Set (0 ms)
[ RUN      ] TestSelectionVector.TestInt16PopulateFromBitMap
/arrow/cpp/src/gandiva/selection_vector_test.cc:116: Failure
Expected equality of these values:
  selection->GetIndex(0)
    Which is: 56
  0
/arrow/cpp/src/gandiva/selection_vector_test.cc:117: Failure
Expected equality of these values:
  selection->GetIndex(1)
    Which is: 61
  5
/arrow/cpp/src/gandiva/selection_vector_test.cc:118: Failure
Expected equality of these values:
  selection->GetIndex(2)
    Which is: 65
  121
[  FAILED  ] TestSelectionVector.TestInt16PopulateFromBitMap (0 ms)
[ RUN      ] TestSelectionVector.TestInt16PopulateFromBitMapNegative
/arrow/cpp/src/gandiva/selection_vector_test.cc:137: Failure
Expected equality of these values:
  status.IsInvalid()
    Which is: false
  true
[  FAILED  ] TestSelectionVector.TestInt16PopulateFromBitMapNegative (0 ms)
[ RUN      ] TestSelectionVector.TestInt32Set
[       OK ] TestSelectionVector.TestInt32Set (0 ms)
[ RUN      ] TestSelectionVector.TestInt32PopulateFromBitMap
/arrow/cpp/src/gandiva/selection_vector_test.cc:187: Failure
Expected equality of these values:
  selection->GetIndex(0)
    Which is: 56
  0
/arrow/cpp/src/gandiva/selection_vector_test.cc:188: Failure
Expected equality of these values:
  selection->GetIndex(1)
    Which is: 61
  5
/arrow/cpp/src/gandiva/selection_vector_test.cc:189: Failure
Expected equality of these values:
  selection->GetIndex(2)
    Which is: 65
  121
[  FAILED  ] TestSelectionVector.TestInt32PopulateFromBitMap (0 ms)
[ RUN      ] TestSelectionVector.TestInt32MakeNegative
[       OK ] TestSelectionVector.TestInt32MakeNegative (0 ms)
[ RUN      ] TestSelectionVector.TestInt64Set
[       OK ] TestSelectionVector.TestInt64Set (0 ms)
[ RUN      ] TestSelectionVector.TestInt64PopulateFromBitMap
/arrow/cpp/src/gandiva/selection_vector_test.cc:252: Failure
Expected equality of these values:
  selection->GetIndex(0)
    Which is: 56
  0
/arrow/cpp/src/gandiva/selection_vector_test.cc:253: Failure
Expected equality of these values:
  selection->GetIndex(1)
    Which is: 61
  5
/arrow/cpp/src/gandiva/selection_vector_test.cc:254: Failure
Expected equality of these values:
  selection->GetIndex(2)
    Which is: 65
  121
[  FAILED  ] TestSelectionVector.TestInt64PopulateFromBitMap (0 ms)
[ RUN      ] TestSelectionVector.TestInt64MakeNegative
[       OK ] TestSelectionVector.TestInt64MakeNegative (0 ms)
[----------] 11 tests from TestSelectionVector (1 ms total)
[----------] 2 tests from TestLruCache
[ RUN      ] TestLruCache.TestEvict
[       OK ] TestLruCache.TestEvict (0 ms)
[ RUN      ] TestLruCache.TestLruBehavior
[       OK ] TestLruCache.TestLruBehavior (0 ms)
[----------] 2 tests from TestLruCache (0 ms total)
[----------] 4 tests from TestToDateHolder
[ RUN      ] TestToDateHolder.TestSimpleDateTime
[       OK ] TestToDateHolder.TestSimpleDateTime (0 ms)
[ RUN      ] TestToDateHolder.TestSimpleDate
[       OK ] TestToDateHolder.TestSimpleDate (0 ms)
[ RUN      ] TestToDateHolder.TestSimpleDateTimeError
[       OK ] TestToDateHolder.TestSimpleDateTimeError (0 ms)
[ RUN      ] TestToDateHolder.TestSimpleDateTimeMakeError
[       OK ] TestToDateHolder.TestSimpleDateTimeMakeError (0 ms)
[----------] 4 tests from TestToDateHolder (1 ms total)
[----------] 3 tests from TestSimpleArena
[ RUN      ] TestSimpleArena.TestAlloc
[       OK ] TestSimpleArena.TestAlloc (0 ms)
[ RUN      ] TestSimpleArena.TestReset1
[       OK ] TestSimpleArena.TestReset1 (0 ms)
[ RUN      ] TestSimpleArena.TestReset2
[       OK ] TestSimpleArena.TestReset2 (0 ms)
[----------] 3 tests from TestSimpleArena (0 ms total)
[----------] 6 tests from TestLikeHolder
[ RUN      ] TestLikeHolder.TestMatchAny
[       OK ] TestLikeHolder.TestMatchAny (0 ms)
[ RUN      ] TestLikeHolder.TestMatchOne
[       OK ] TestLikeHolder.TestMatchOne (0 ms)
[ RUN      ] TestLikeHolder.TestPcreSpecial
[       OK ] TestLikeHolder.TestPcreSpecial (0 ms)
[ RUN      ] TestLikeHolder.TestRegexEscape
[       OK ] TestLikeHolder.TestRegexEscape (0 ms)
[ RUN      ] TestLikeHolder.TestDot
[       OK ] TestLikeHolder.TestDot (0 ms)
[ RUN      ] TestLikeHolder.TestOptimise
[       OK ] TestLikeHolder.TestOptimise (1 ms)
[----------] 6 tests from TestLikeHolder (1 ms total)
[----------] 1 test from DecimalResultTypes
[ RUN      ] DecimalResultTypes.Basic
[       OK ] DecimalResultTypes.Basic (0 ms)
[----------] 1 test from DecimalResultTypes (0 ms total)
[----------] 4 tests from TestRandGenHolder
[ RUN      ] TestRandGenHolder.NoSeed
[       OK ] TestRandGenHolder.NoSeed (0 ms)
[ RUN      ] TestRandGenHolder.WithValidEqualSeeds
[       OK ] TestRandGenHolder.WithValidEqualSeeds (0 ms)
[ RUN      ] TestRandGenHolder.WithValidSeeds
[       OK ] TestRandGenHolder.WithValidSeeds (0 ms)
[ RUN      ] TestRandGenHolder.WithInValidSeed
[       OK ] TestRandGenHolder.WithInValidSeed (0 ms)
[----------] 4 tests from TestRandGenHolder (0 ms total)
[----------] Global test environment tear-down
[==========] 60 tests from 17 test cases ran. (157 ms total)
[  PASSED  ] 56 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] TestSelectionVector.TestInt16PopulateFromBitMap
[  FAILED  ] TestSelectionVector.TestInt16PopulateFromBitMapNegative
[  FAILED  ] TestSelectionVector.TestInt32PopulateFromBitMap
[  FAILED  ] TestSelectionVector.TestInt64PopulateFromBitMap
 4 FAILED TESTS
...

Reporter: Kazuaki Ishizaki / @kiszk
Assignee: Kazuaki Ishizaki / @kiszk

PRs and other links:

Note: This issue was originally created as ARROW-8778. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Kouhei Sutou / @kou:
Issue resolved by pull request 7161
#7161

@asfimport asfimport added this to the 1.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants