Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] [Parquet] Fix compiler warning about unused return value #26122

Closed
Tracked by #26004
asfimport opened this issue Sep 27, 2020 · 2 comments
Closed
Tracked by #26004

[Rust] [Parquet] Fix compiler warning about unused return value #26122

asfimport opened this issue Sep 27, 2020 · 2 comments

Comments

@asfimport
Copy link

When compiling with latest nightly, this warning is produced:

warning: unused return value of `std::mem::replace` that must be used
   --> parquet/src/encodings/encoding.rs:391:9
    |
391 |         mem::replace(&mut self.hash_slots, new_hash_slots);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: if you don't need the old value, you can just assign the new value directly 

Reporter: Andy Grove / @andygrove
Assignee: Neville Dipale / @nevi-me

Note: This issue was originally created as ARROW-10108. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Neville Dipale / @nevi-me:
There are a lot of clippy issues with the latest nightly too, perhaps we could move to the latest nightly after the 2.0.0 release? I'd also like for us to perform destructive refactors soon as possible after the release (rearranging the arrow::array module by splitting arrays into their own files)

@asfimport
Copy link
Author

Neville Dipale / @nevi-me:
This was fixed as part of the nightly update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants