Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Cargo build is rebuilding dependencies on arrow changes #26141

Closed
asfimport opened this issue Sep 29, 2020 · 4 comments
Closed

[Rust] Cargo build is rebuilding dependencies on arrow changes #26141

asfimport opened this issue Sep 29, 2020 · 4 comments

Comments

@asfimport
Copy link

There is a potential issue in the dependencies causing rust to re-build them on changes of the arrow crate.

I was unable to fully grasp what is going on, but this seems to be a re-surface of ARROW-9600

Reporter: Jorge Leitão / @jorgecarleitao

Note: This issue was originally created as ARROW-10129. Please see the migration documentation for further details.

@asfimport
Copy link
Author

Jorge Leitão / @jorgecarleitao:
@andygrove or @alamb , do you experience this?

@asfimport
Copy link
Author

Andrew Lamb / @alamb:
@jorgecarleitao I have not:

alamb@ip-192-168-1-129:~/Software/arrow/rust$ git status
On branch master
Your branch is up to date with 'upstream/master'.

nothing to commit, working tree clean
alamb@ip-192-168-1-129:~/Software/arrow/rust$ cargo build
    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
alamb@ip-192-168-1-129:~/Software/arrow/rust$ cargo build
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s

@asfimport
Copy link
Author

Andrew Lamb / @alamb:
When I change arrow itself, a bunch of related workspace crates do recompile, but I think that is expected (as they depend on arrow):

alamb@ip-192-168-1-129:~/Software/arrow/rust$ touch arrow/src/array/array.rs 
alamb@ip-192-168-1-129:~/Software/arrow/rust$ cargo build
   Compiling arrow v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/arrow)
   Compiling parquet v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/parquet)
   Compiling arrow-integration-testing v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/integration-testing)
   Compiling arrow-flight v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/arrow-flight)
   Compiling datafusion v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/datafusion)
   Compiling parquet_derive v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/parquet_derive)
   Compiling arrow-benchmarks v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/benchmarks)
   Compiling parquet_derive_test v2.0.0-SNAPSHOT (/Users/alamb/Software/arrow/rust/parquet_derive_test)
    Finished dev [unoptimized + debuginfo] target(s) in 10.95s

@asfimport
Copy link
Author

Todd Farmer / @toddfarmer:
Transitioning issue from Resolved to Closed to based on resolution field value.

@asfimport asfimport added this to the 2.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant