Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] ArrowTable::load test fails due to undefined method #26209

Closed
assignUser opened this issue Jan 10, 2023 · 1 comment · Fixed by #33602
Closed

[Ruby] ArrowTable::load test fails due to undefined method #26209

assignUser opened this issue Jan 10, 2023 · 1 comment · Fixed by #33602
Assignees
@kou
Labels
Component: Ruby Type: bug
Milestone
11.0.0

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/3822668197/jobs/6503035048#step:5:12051
Error: test_filter(TestArrowTable::load): NoMethodError: undefined method end_with?' for :set_inspect_n_fragments:Symbol`

Probably caused by #15148
cc @kou

Component(s)

Ruby
@kou
Copy link
Member

kou commented Jan 10, 2023

Oh, sorry. I didn't notice it. I'll fix it soon.

kou added a commit to kou/arrow that referenced this issue Jan 11, 2023
@kou
apacheGH-26209: [Ruby] Add support for Ruby 2.5
a1c0420 
Ruby 2.5 was EOL but Ubuntu 18.04 still uses Ruby 2.5.
Note that Ubuntu 18.04 will reach EOL on 2023-04.
@kou kou mentioned this issue Jan 11, 2023
Merged
kou added a commit that referenced this issue Jan 11, 2023
@kou
GH-26209: [Ruby] Add support for Ruby 2.5 (#33602)
872bbda 
# Which issue does this PR close?

Closes #26209

# Rationale for this change

Ruby 2.5 was EOL but Ubuntu 18.04 still uses Ruby 2.5. Note that Ubuntu 18.04 will reach EOL on 2023-04.

# What changes are included in this PR?

Ruby 2.5 compatible implementation and tests.

# Are these changes tested?

Yes

# Are there any user-facing changes?

No.

* Closes: #26209

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Ruby Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-26209: [Ruby] Add support for Ruby 2.5 kou/arrow
2 participants
@kou @assignUser