Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Decimal] Get rid of code duplication at Decimal #26455

Open
Tracked by #25483
asfimport opened this issue Nov 3, 2020 · 1 comment
Open
Tracked by #25483

[C++][Decimal] Get rid of code duplication at Decimal #26455

asfimport opened this issue Nov 3, 2020 · 1 comment

Comments

@asfimport
Copy link
Collaborator

asfimport commented Nov 3, 2020

In classes related to Decimal types: DecimalArray, DecimalBuilder, DecimalType, etc, there is a lot of code duplications between decimals with different bit widths.

The proposal here is to create base classes for them, that will contain common logic for decimals of all bit widths.

These changes should simplify adding of new width decimals to C++ part.

Reporter: Dmitry Chigarev

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-10479. Please see the migration documentation for further details.

@asfimport
Copy link
Collaborator Author

Stephen Yuan Jiang:
Hello, Dmitry, any ETA on ARROW-9404 to support decimal64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant